Merge pull request #488 from RHEAGROUP/Fix/remove-duplicate-extension…

…-method-present-on-sdk Fix/remove duplicate extension method present on sdk
STARIONGROUP · Nov 30, 2023 · bc41740 · bc41740
2 parents 51e62d5 + f18c472
commit bc41740
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 23 deletions.
diff --git a/COMET.Web.Common.Tests/Extensions/ValueArrayExtensionsTestFixture.cs b/COMET.Web.Common.Tests/Extensions/ValueArrayExtensionsTestFixture.cs
@@ -27,6 +27,7 @@ namespace COMET.Web.Common.Tests.Extensions
 {
     using System.Collections.Generic;
 
+    using CDP4Common.Helpers;
     using CDP4Common.Types;
 
     using COMET.Web.Common.Extensions;

diff --git a/COMET.Web.Common/Extensions/ValueArrayExtensions.cs b/COMET.Web.Common/Extensions/ValueArrayExtensions.cs
@@ -32,28 +32,6 @@ namespace COMET.Web.Common.Extensions
 	/// </summary>
 	public static class ValueArrayExtensions
     {
-        /// <summary>
-        /// Checks if two <see cref="ValueArray{T}"/> contains the same exact values 
-        /// </summary>
-        /// <typeparam name="T">the type of the parameter</typeparam>
-        /// <param name="valueArray">the first value array to compare</param>
-        /// <param name="comparison">the second value array to compare</param>
-        /// <returns>True if the contained values are the same, false otherwise</returns>
-        public static bool ContainsSameValues<T>(this ValueArray<T> valueArray, ValueArray<T> comparison) where T : class
-        {
-            if (comparison is null)
-            {
-                throw new ArgumentNullException(nameof(comparison));
-            }
-
-            if (valueArray.Count != comparison.Count)
-            {
-                return false;
-            }
-
-            return !valueArray.Where((t, i) => !t.Equals(comparison[i])).Any();
-        }
-
         /// <summary>
         /// Adds new default values inside a <see cref="ValueArray{T}"/>
         /// </summary>

diff --git a/COMET.Web.Common/ViewModels/Components/ParameterEditors/OrientationViewModel.cs b/COMET.Web.Common/ViewModels/Components/ParameterEditors/OrientationViewModel.cs
@@ -138,7 +138,7 @@ public Task OnMatrixValuesChanged(int index, string value)
         {
             var orientationMatrix = this.Orientation.Matrix;
 
-            if (double.TryParse(value, out var valueParsed))
+            if (double.TryParse(value, CultureInfo.InvariantCulture, out var valueParsed))
             {
                 orientationMatrix[index] = valueParsed;
                 this.Orientation = new Orientation(orientationMatrix, this.AngleFormat);

diff --git a/COMETwebapp/Extensions/ParameterValueSetRelationExtensions.cs b/COMETwebapp/Extensions/ParameterValueSetRelationExtensions.cs
@@ -25,6 +25,7 @@
 namespace COMETwebapp.Extensions
 {
     using CDP4Common.EngineeringModelData;
+    using CDP4Common.Helpers;
 
     using COMET.Web.Common.Extensions;