Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/BookApplication #456

Merged
merged 20 commits into from
Sep 21, 2023
Merged

Feat/BookApplication #456

merged 20 commits into from
Sep 21, 2023

Conversation

jaimeatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

This PR implements the BookEditor application

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 69.91% and project coverage change: +0.69% 🎉

Comparison is base (6cd6b15) 77.04% compared to head (785977a) 77.74%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #456      +/-   ##
===============================================
+ Coverage        77.04%   77.74%   +0.69%     
===============================================
  Files              310      323      +13     
  Lines             6980     7464     +484     
  Branches           713      754      +41     
===============================================
+ Hits              5378     5803     +425     
- Misses            1394     1436      +42     
- Partials           208      225      +17     
Files Changed Coverage Δ
....Common/Components/BookEditor/InputEditor.razor.cs 33.33% <33.33%> (ø)
...Twebapp/Components/BookEditor/BookEditorBody.razor 40.00% <40.00%> (ø)
...ommon/Services/SessionManagement/SessionService.cs 55.29% <47.22%> (-2.17%) ⬇️
....Common/Components/BookEditor/EditorPopup.razor.cs 47.36% <47.36%> (ø)
...pp/Components/BookEditor/BookEditorColumn.razor.cs 55.00% <55.00%> (ø)
...s/Components/BookEditor/BookEditorBodyViewModel.cs 74.67% <74.67%> (ø)
...dels/Components/BookEditor/EditorPopupViewModel.cs 77.77% <77.77%> (ø)
...Web.Common/Components/BookEditor/InputEditor.razor 80.00% <80.00%> (ø)
...Web.Common/Components/BookEditor/EditorPopup.razor 83.33% <83.33%> (ø)
...ebapp/Components/BookEditor/BookEditorColumn.razor 90.32% <90.32%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@antoineatstariongroup antoineatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR overall, some minor change. Could you please fix Code Smell and bring code coverage at 70% ? Thanks

@typeparam TItem

@{
var columnConditionalClass = this.IsCollapsed ? "collapsed" : "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this as private properties, inside the cs file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are indeed properties of the component. However adding variables for the conditional classes is preferable in the razor component. It's easier to debug.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

72.0% 72.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@jaimeatstariongroup jaimeatstariongroup merged commit 669dd5f into development Sep 21, 2023
8 of 9 checks passed
@jaimeatstariongroup jaimeatstariongroup deleted the Feat/BookApplication branch September 21, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants