Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #457: Supports of Blazor Server #461

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

antoineatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #457

  • Common library can be register for WASM or for Blazor Server
  • WebApp updates to call correct registration of the Common library

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (71a4c6d) 77.70% compared to head (6fe5cfc) 78.42%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #461      +/-   ##
===============================================
+ Coverage        77.70%   78.42%   +0.71%     
===============================================
  Files              323      328       +5     
  Lines             7464     7513      +49     
  Branches           754      760       +6     
===============================================
+ Hits              5800     5892      +92     
+ Misses            1438     1391      -47     
- Partials           226      230       +4     
Files Coverage Δ
...OMET.Web.Common.Test/Helpers/MockedLoggerHelper.cs 100.00% <100.00%> (ø)
COMET.Web.Common/Components/Dashboard.razor.cs 100.00% <100.00%> (ø)
COMET.Web.Common/Components/Login.razor.cs 100.00% <ø> (ø)
COMET.Web.Common/Components/OpenModel.razor.cs 96.77% <100.00%> (ø)
...onents/SingleIterationApplicationTemplate.razor.cs 98.38% <100.00%> (ø)
...b.Common/Extensions/ServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...Web.Common/Extensions/ServiceProviderExtensions.cs 100.00% <100.00%> (ø)
...vices/ConfigurationService/ConfigurationService.cs 100.00% <100.00%> (ø)
...s/ConfigurationService/BaseConfigurationService.cs 100.00% <100.00%> (ø)
...vices/StringTableService/BaseStringTableService.cs 100.00% <100.00%> (ø)
... and 11 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoineatstariongroup
Copy link
Contributor Author

@samatrhea I'll increase code coverage before merging

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.1% 92.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@antoineatstariongroup antoineatstariongroup merged commit 02abd68 into development Oct 3, 2023
9 checks passed
@antoineatstariongroup antoineatstariongroup deleted the feat/GH457-support-server-side branch October 3, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server] Supports Blazor Server
2 participants