Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the InputEditor #462

Merged
merged 10 commits into from
Oct 4, 2023

Conversation

Robbware
Copy link
Contributor

@Robbware Robbware commented Oct 3, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

The following changes will allow us to show/hide the Name and Short name fields on the InputEditor, via a configuration file. Additionally, a MultiComboBox component was created as DevExpress, by default, does not have a dropdown component which enables multiple choice.

@Robbware Robbware added the improvement an improvement to the COMET architectrure, not an enhancement to user experience label Oct 3, 2023
@Robbware Robbware self-assigned this Oct 3, 2023
@Robbware
Copy link
Contributor Author

Robbware commented Oct 3, 2023

Fixing the failing tests.

Copy link
Contributor

@jaimeatstariongroup jaimeatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small requests

.gitignore Outdated
@@ -349,3 +349,6 @@ MigrationBackup/
# Ionide (cross platform F# VS Code tools) working folder
.ionide/
/COMETwebapp/Tools

# Jetbrains folders
.idea/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line at the end of the file

COMET.Web.Common/Components/MultiComboBox.razor.cs Outdated Show resolved Hide resolved
COMET.Web.Common/Components/MultiComboBox.razor.css Outdated Show resolved Hide resolved
…ext fixtures to match the new business rules and changes made.
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (82520af) 78.38% compared to head (8d464e2) 78.31%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #462      +/-   ##
===============================================
- Coverage        78.38%   78.31%   -0.07%     
===============================================
  Files              328      330       +2     
  Lines             7513     7600      +87     
  Branches           760      772      +12     
===============================================
+ Hits              5889     5952      +63     
- Misses            1393     1414      +21     
- Partials           231      234       +3     
Files Coverage Δ
...Web.Common/Components/BookEditor/InputEditor.razor 81.25% <81.25%> (+1.25%) ⬆️
....Common/Components/BookEditor/InputEditor.razor.cs 78.57% <90.90%> (+45.23%) ⬆️
COMET.Web.Common/Components/MultiComboBox.razor.cs 42.10% <42.10%> (ø)
COMET.Web.Common/Components/MultiComboBox.razor 61.76% <61.76%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbware
Copy link
Contributor Author

Robbware commented Oct 3, 2023

Working on the coverage, just a bit more 😉

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.8% 75.8% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Robbware Robbware merged commit 81802a7 into development Oct 4, 2023
7 of 9 checks passed
@Robbware Robbware deleted the Feat/BookApplicationImprovements branch October 4, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement an improvement to the COMET architectrure, not an enhancement to user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants