Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing namespace to MultiComboBox component #465

Merged

Conversation

Robbware
Copy link
Contributor

@Robbware Robbware commented Oct 4, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Add a missing namespace to the new MultiComboBox component which was blocking the nuget package from being built.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8d464e2) 78.31% compared to head (42c9517) 78.31%.
Report is 2 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #465   +/-   ##
============================================
  Coverage        78.31%   78.31%           
============================================
  Files              330      330           
  Lines             7600     7600           
  Branches           772      772           
============================================
  Hits              5952     5952           
  Misses            1414     1414           
  Partials           234      234           
Files Coverage Δ
COMET.Web.Common/Components/MultiComboBox.razor 61.76% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Robbware Robbware merged commit 4bea92c into development Oct 4, 2023
@Robbware Robbware deleted the Fix/BookApplicationImprovements-MissingNamespace branch October 4, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants