Fix the BookInputConfiguration failing upon validations being run. #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the parent component first (where the validations are made) and set to the child component.
Robbware
added
the
bug
| @@ -47,6 +47,8 @@ namespace COMET.Web.Common.Tests.Components.BookEditor | |||
|
|
|||
| using NUnit.Framework; | |||
|
|
|||
| using RichardSzalay.MockHttp; | |||
There was a problem hiding this comment.
Where is this dependency comming from?
There was a problem hiding this comment.
This is used for MockHttpMessageHandler (also on other fixtures in the project). Either way, one of the tests I modified had this using but it wasn't in use so I've removed it.
|
Kudos, SonarCloud Quality Gate passed!
|
jaimeatstariongroup
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I've had to refactor this so that we read the configuration on the parent component (the EditorPopup) instead of the child component (the InputEditor) as the validations were being done on the EditorPopup and since that component wasn't aware that the fields were hidden, the validations would fail upon submission.