Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #181 (1067 - Gitlab): login bug #467

Merged
merged 19 commits into from
Oct 10, 2023
Merged

Conversation

joao4all
Copy link
Contributor

@joao4all joao4all commented Oct 4, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fixed #181 Gitlab bug

Solved problems with login page: now focused components will not show their error message. BindValueMode updated

Copy link
Contributor

@antoineatstariongroup antoineatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small documentation missing. Could be nice to increase code coverage by testing cases on the Component

COMET.Web.Common/Components/Login.razor.cs Outdated Show resolved Hide resolved
COMET.Web.Common/Components/Login.razor.cs Outdated Show resolved Hide resolved
- Comments added
- Testing focus and blur functionalities
joao4all and others added 6 commits October 6, 2023 16:32
Changing conditional to show source address, given the current way to do it, through serverconnectionservice.serverconfiguration.serveraddress
Revert "Add the ability to override the TopMenu component on the MainLayout"

This reverts commit 46c3043.

Use IOC to load all Items within the TopMenu
Robbware and others added 8 commits October 10, 2023 08:49
…ype-on-mainlayout

Add the ability to override the TopMenu component on the MainLayout via IOC
- Comments added
- Testing focus and blur functionalities
Changing conditional to show source address, given the current way to do it, through serverconnectionservice.serverconfiguration.serveraddress
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.0% 86.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@joao4all joao4all merged commit ded0302 into development Oct 10, 2023
7 checks passed
@joao4all joao4all deleted the bug/GL181-login-bug branch October 10, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants