Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #477- ApplicationTemplate can be used as is #478

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

antoineatstariongroup
Copy link
Contributor

@antoineatstariongroup antoineatstariongroup commented Oct 14, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #477
GenericApplicationTemplate created to handle the Generic (required for subcomponent) and implementation of ApplicationTemplate. The ApplicationTemplate can be used now.

Cleanup encoding and tab for ThingExtension file

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@antoineatstariongroup antoineatstariongroup merged commit 2bb2c85 into development Oct 16, 2023
7 checks passed
@antoineatstariongroup antoineatstariongroup deleted the feat/GH477-applicationtemplate branch October 16, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApplicationTemplate: remove generic
2 participants