Feat/add-namingconventions-service-and-cherrypick #481
Conversation
…it can work for any type of enum that is provided via IOC
…it can work for any type of enum that is provided via IOC
…https://github.com/RHEAGROUP/COMET-WEB-Community-Edition into Feat/move-bookconfiguration-to-configurationservices
|
|
||
| foreach (var namingConventionKind in enumValues) | ||
| { | ||
| Assert.Multiple(() => |
There was a problem hiding this comment.
move the assert.Multiple around the foreach
Robbware
changed the title
… and WASM modes. Add new test fixtures for WASM mode. Add two loading types (file loading and via http request).
COMET.Web.Common.Tests/Utilities/CherryPick/CherryPickRunnerTestFixture.cs
Outdated
Show resolved
Hide resolved
...mon.Tests/WebAssembly/Services/NamingConventionService/NamingConventionServiceTestFixture.cs
Outdated
Show resolved
Hide resolved
COMET.Web.Common/Server/Services/NamingConventionService/NamingConventionService.cs
Show resolved
Hide resolved
COMET.Web.Common/Server/Services/NamingConventionService/NamingConventionService.cs
Show resolved
Hide resolved
COMET.Web.Common/Services/NamingConventionService/BaseNamingConventionService.cs
Outdated
Show resolved
Hide resolved
COMET.Web.Common/Services/NamingConventionService/BaseNamingConventionService.cs
Outdated
Show resolved
Hide resolved
COMET.Web.Common/Services/NamingConventionService/BaseNamingConventionService.cs
Outdated
Show resolved
Hide resolved
| /// <exception cref="NotImplementedException"></exception> | ||
| public virtual Task<IReadOnlyDictionary<string, string>> GetNamingConventionConfiguration() | ||
| { | ||
| throw new NotImplementedException(); |
There was a problem hiding this comment.
why throwing exception there? You could just return the definedNaming dictionary ?
There was a problem hiding this comment.
That would be a bit irrelevant for this method as that collection hasn't been filled up - the goal would be for any class that inherit this one would have to override this method themselves, depending on how they want to retrieve the configuration.
I could, however, just return an empty dictionary, if you prefer it like that
There was a problem hiding this comment.
Understood, took me a bit time to follow your implementation. My recommendation for this case : put the Base class as abstract and set that method abstract also. It will force any subclass to implement it (which is what we want). That base class will never be used as a concrete class anyway
COMET.Web.Common/Services/NamingConventionService/INamingConventionService.cs
Show resolved
Hide resolved
COMET.Web.Common/Services/NamingConventionService/INamingConventionService.cs
Outdated
Show resolved
Hide resolved
… GetNamingConventionConfiguration method as abstract too
…ld only be used and/or seen by the classes that implement the BaseNamingConventionService
|
Kudos, SonarCloud Quality Gate passed!
|
Robbware
deleted the
Feat/move-bookconfiguration-to-configurationservices
branch
Prerequisites
Description
This allows for the common library to have access to a better layer of the CherryPick functionality and a structured and predefined way of accessing the NamingConventions configuration.