Feat/482 add specific cherrypick method #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ick on a specific engineering model and iteration.
…rryPick methods instead of a single specific parameter.
antoineatstariongroup
approved these changes
Oct 20, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This provides the ability for us to specifically run a CherryPick on a particular engineering model and iteration.
@antoineatrhea This is slightly different than what we had envisioned yesterday but I felt that the code was not becoming clear enough when attempting to fuse the two methods (so that we'd have the RunCherryPick() running the RunSingleCherryPick() inside it). As such, I opted by extracting some common denominators from the logic and keeping things separate.