Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/allow multicombobox to set readonly #487

Merged
merged 2 commits into from
Nov 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions COMET.Web.Common.Tests/Components/MultiComboBoxTestFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,21 @@ public void SetUp()
new() { Name = "Category4" },
new() { Name = "Category5" },
};

}

[TestCase(true, false)]
[TestCase(false, false)]
[TestCase(false, true)]
public async Task VerifyComponent(bool isComponentEnabled, bool isComponentReadOnly)
{
this.component = this.context.RenderComponent<MultiComboBox<Category>>(parameter =>
{
parameter.Add(p => p.Data, this.availableCategories);
parameter.Add(p => p.Values, this.availableCategories);
parameter.Add(p => p.ShowCheckBoxes, true);
parameter.Add(p => p.MaxNumberOfChips, 2);
parameter.Add(p => p.Enabled, true);
parameter.Add(p => p.Enabled, isComponentEnabled);
parameter.Add(p => p.IsReadOnly, isComponentReadOnly);

parameter.Add(p => p.EditorTextTemplate, builder =>
{
Expand All @@ -78,14 +85,9 @@ public void SetUp()

parameter.Add(p => p.RowTemplate, value => value.Name);
});
}

[Test]
public async Task VerifyComponent()
{

Assert.Multiple(() =>
{
Assert.IsTrue(this.component.Instance.Enabled);
Assert.IsNotEmpty(this.component.Instance.Data);
Assert.IsNotEmpty(this.component.Instance.Values);
Assert.IsTrue(this.component.Instance.ShowCheckBoxes);
Expand All @@ -95,15 +97,25 @@ public async Task VerifyComponent()
});

var comboBox = this.component.FindComponent<DxComboBox<Category, Category>>();
Assert.IsNotNull(comboBox);
Assert.IsNull(comboBox.Instance.Value);

Assert.Multiple(() =>
{
Assert.IsNotNull(comboBox);
Assert.IsNull(comboBox.Instance.Value);
Assert.That(comboBox.Instance.ReadOnly, Is.EqualTo(isComponentReadOnly));
Assert.That(comboBox.Instance.Enabled, Is.EqualTo(isComponentEnabled));
});

await this.component.InvokeAsync(() => comboBox.Instance.ShowDropDown());

var dropdownItems = this.component.FindAll(".item-template-checkbox");
Assert.IsNotNull(dropdownItems);
Assert.IsNotEmpty(dropdownItems);
Assert.AreEqual(this.availableCategories.Count, dropdownItems.Count);

Assert.Multiple(() =>
{
Assert.IsNotNull(dropdownItems);
Assert.IsNotEmpty(dropdownItems);
Assert.AreEqual(this.availableCategories.Count, dropdownItems.Count);
});
}
}
}
1 change: 1 addition & 0 deletions COMET.Web.Common/Components/MultiComboBox.razor
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
Data="@this.Data"
ValueChanged="@this.ItemSelected"
Enabled="@this.Enabled"
ReadOnly="@(this.IsReadOnly)"
Value="@this.lastSelectedValue"
ClearButtonDisplayMode="DataEditorClearButtonDisplayMode.Auto"
CssClass="w-100">
Expand Down
12 changes: 10 additions & 2 deletions COMET.Web.Common/Components/MultiComboBox.razor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ public partial class MultiComboBox<TItem>
public IEnumerable<TItem> Data { get; set; } = Enumerable.Empty<TItem>();

/// <summary>
/// Gets or sets if the component should show all the fields as readonly
/// Gets or sets if the component should show all the fields as enabled/disabled.
/// If a component is disabled, the user can't select the values within the component.
/// </summary>
[Parameter]
public bool Enabled { get; set; } = true;
Expand All @@ -83,7 +84,14 @@ public partial class MultiComboBox<TItem>
/// Gets or sets the callback used to update the component value
/// </summary>
[Parameter]
public EventCallback<List<TItem>> ValuesChanged { get; set; }
public EventCallback<List<TItem>> ValuesChanged { get; set; }

/// <summary>
/// Gets or sets if the component is read only.
/// If a component is read only, the user can select the values but not edit them.
/// </summary>
[Parameter]
public bool IsReadOnly { get; set; }

/// <summary>
/// Handler for when the value of the component has changed
Expand Down
Loading