Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #475: Added EngineeringModelId inside Template and improvement #492

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix #475: Added EngineeringModelId inside Template and improvement #492

merged 1 commit into from
Jan 8, 2024

Conversation

antoineatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #475

  • Added parameter EngineeringModelId inside SingleEngineeringModelApplicationTemplate
  • Behavior improved for Single(Interation/EngineeringModel)ApplicationTemplate to set properties directly on Initialization => Possibility to not have multiple url history when preselecting the Iteration/EngineeringModel
  • Test aligned with changes

@antoineatstariongroup antoineatstariongroup self-assigned this Jan 2, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
98.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@antoineatstariongroup antoineatstariongroup merged commit 1611f87 into development Jan 8, 2024
6 checks passed
@antoineatstariongroup antoineatstariongroup deleted the feat/GH475-modelId-parameter branch January 8, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimeatstariongroup jaimeatstariongroup jaimeatstariongroup approved these changes

@samatstariongroup samatstariongroup Awaiting requested review from samatstariongroup

Assignees

@antoineatstariongroup antoineatstariongroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SingleEngineeringModelApplicationTemplate: Missing Parameter ModelId
2 participants
@antoineatstariongroup @jaimeatstariongroup