Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat #557 As a user i want to show the options of a model and create, edit and delete an option #570

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Feat #557 As a user i want to show the options of a model and create, edit and delete an option #570

merged 4 commits into from
Apr 8, 2024

Conversation

joao4all
Copy link
Contributor

@joao4all joao4all commented Apr 8, 2024 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Closes #557 As a user i want to show the options of a model and create, edit and delete an option

joao4all added 4 commits April 5, 2024 17:30
@joao4all
engineering model page created + options table created
1dd7a17 
TODO:
- Implement options form component
- Implement dynamic component in engineering model body for options
- Write unit tests
@joao4all
finished implementation
31eac0b
@joao4all
unit tests for validator and viewmodels
d7a4337
@joao4all
tests for components
632378f
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@joao4all joao4all merged commit d29ecd2 into development Apr 8, 2024
6 checks passed
@joao4all joao4all deleted the feat/GH557-crud-options-of-an-engineering-model branch April 17, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoineatstariongroup antoineatstariongroup antoineatstariongroup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a user i want to show the options of a model and create, edit and delete an option
2 participants
@joao4all @antoineatstariongroup