-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat #559 As a user i want to manipulate the folder-file structure of a filestore #578
Merged
joao4all
merged 12 commits into
development
from
feat/GH559-manipulate-folder-file-structure-of-a-filestore
Apr 17, 2024
Merged
Feat #559 As a user i want to manipulate the folder-file structure of a filestore #578
joao4all
merged 12 commits into
development
from
feat/GH559-manipulate-folder-file-structure-of-a-filestore
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO - Add suport to move folder to folder - Handle edge cases - Upload/download file - Create/Edit files/folders - Unit tests
TODO - Create folder + create/edit file - Handle more edge cases - Upload/download file (this should include file revisions) - Unit tests
TODO - Improve file revision form (add support to multiple filetypes) - Add validation - Improve design for revisions table - Refactor code - Unit tests
… + code refactored TODO - Validation - Unit tests
TODO - Unit tests
…f non existing files
TODO - Unit tests for components
antoineatstariongroup
requested changes
Apr 17, 2024
COMET.Web.Common.Tests/Services/SessionManagement/SessionServiceTestFixture.cs
Outdated
Show resolved
Hide resolved
...ls/Components/EngineeringModel/FileStore/FileRevisionHandler/FileRevisionHandlerViewModel.cs
Outdated
Show resolved
Hide resolved
JaimeBernar
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but fix Antoine's comments first
joao4all
requested review from
antoineatstariongroup
and removed request for
jaimeatstariongroup
April 17, 2024 08:07
Quality Gate passedIssues Measures |
antoineatstariongroup
approved these changes
Apr 17, 2024
joao4all
deleted the
feat/GH559-manipulate-folder-file-structure-of-a-filestore
branch
April 30, 2024 10:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Closes #559 As a user i want to manipulate the folder-file structure of a filestore