Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat #586 [Reference Data] As a user I want to be able to create and edit a Measurement Scale #587

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Feat #586 [Reference Data] As a user I want to be able to create and edit a Measurement Scale #587

merged 5 commits into from
Apr 26, 2024

Conversation

joao4all
Copy link
Contributor

@joao4all joao4all commented Apr 24, 2024 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Closes #586 [Reference Data] As a user I want to be able to create and edit a Measurement Scale

joao4all added 3 commits April 23, 2024 12:27
@joao4all
cyclic ratio, interval, ordinal and rate scales creation/edit impleme…
697f5bc 
…nted + mappings and scale value definitions

TODO
- Support logarithmic scale data
- Show error message in case of invalid data
- Validation
- Unit tests
@joao4all
support for logarithmic scale + validations + layout updated
e3f4336 
TODO
- Unit tests
@joao4all
unit tests implemented
f445fbc
@joao4all joao4all force-pushed the feat/GH586-create-or-edit-measurement-scale branch from 87d234e to f445fbc Compare April 24, 2024 12:22
antoineatstariongroup
antoineatstariongroup requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@antoineatstariongroup antoineatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update headers file

...Tests/Components/ReferenceData/MeasurementScales/MappingToReferenceScalesTableTestFixture.cs Outdated Show resolved Hide resolved
COMETwebapp/Components/ReferenceData/MeasurementScales/MappingToReferenceScalesTable.razor Outdated Show resolved Hide resolved
@joao4all joao4all merged commit 06405f2 into development Apr 26, 2024
3 of 5 checks passed
@joao4all joao4all deleted the feat/GH586-create-or-edit-measurement-scale branch April 30, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoineatstariongroup antoineatstariongroup antoineatstariongroup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Reference Data] As a user I want to be able to create and edit a Measurement Scale
2 participants
@joao4all @antoineatstariongroup