Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CardView Component;fixes #725 #732

Merged
merged 14 commits into from
Dec 16, 2024

Conversation

lxatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

[WIP] CardView Component;fixes #725

Copy link
Member

@samatstariongroup samatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add newlines at the end of each file

COMET.Web.Common/Components/CardView/CardView.razor Outdated Show resolved Hide resolved
Copy link
Member

@samatstariongroup samatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have a look at https://sonarcloud.io/summary/new_code?id=STARIONGROUP_COMET-WEB-Community-Edition&pullRequest=732

coverage needs to be higher and the rating needs to be A

@lxatstariongroup lxatstariongroup marked this pull request as ready for review December 16, 2024 13:06
@lxatstariongroup lxatstariongroup merged commit 7cd9b4c into development Dec 16, 2024
13 checks passed
@samatstariongroup samatstariongroup deleted the feat/gh725-introduce-CardView branch December 16, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Model Editor - Parameter grid using a Card (tile) that displays the information
2 participants