Implementation of surface integral within update rule #5
+259
−1,377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the cell mask to integer and made normal cells 1, boundary cells -1 and cells inside the obstacle are of value 0. When assigning ids the normal cells count up while the boundary cells have negative ids.
Improving the Boundary Cell detection by making the implementation more efficient by checking if one point is outside of the obstacle instead of all inside and changing the layering of Ids to work better with multiple obstacles
There was an error in calculating the Verticies for the cells which meant that a bigger area then the cell was checked. Now it should be correct.
Made Pluto use a local version of the Euler2D Package. This sadly means that Plutos Package Manger cannot be used so I added the required Packages to the Project.toml file. This should be changed again later.
For Cells which are identified as cells that intersect with the boundart of the obstacle, the intersection points with the cell border are now calculated and stored as SVectors in the Cell Structs.
Moved the calculation of the surface integrals and normals into the partitioning part of the Workflow to minimize calculations necessary at run time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the functions: 'calculate_normal_vector_circle' and 'surface_integral_circle' to the grid.jl file and use then within 'compute_cell_update_and_max_\Deltat' to update the update rule.
Note: Only implemented for PrimalQuadMode and for the case in which obstacle is a circle.