-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bindings for hpx/algorithm.hpp #7
Conversation
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
@SAtacker my hpx::copy_n is wrong, currently for first argument(as per docs refer to
|
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
I don't have a preference given my limited experience with rust. I would prefer efficiency i.e. instead of creating an expensive temporary allocated array with vec.begin()+offset as starting element I would prefer no-copy reference to the remaining part of the elements since it is a copy operation. Does that makes sense, or did I miss anything? |
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the src
vector instead of the cpp_src
avoiding reconstruction.
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
Signed-off-by: Dikshant <[email protected]>
@SAtacker this is the code-coverage report using cargo-llvm-cov The following functions are not covered:
|
Algos Done: