feat(components/molecule/phoneInput): add onPrefixChange prop #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecting changes from selected pr
1izpena
requested review from
sui-bot,
kikoruiz,
andresin87 and
andresz1
as code owners
|
xaviermariaconejo
approved these changes
Sep 28, 2023
| @@ -77,6 +79,11 @@ export default function MoleculePhoneInput({ | |||
| } | |||
| }, []) | |||
|
|
|||
| useEffect(() => { | |||
| onPrefixChange(selectedPrefix) | |||
There was a problem hiding this comment.
Tal vez si que haria que en el nuevo onPrefixChange, devolviera el mismo objeto que devuelve el onChange, es decir {name, prefix, value}
jordevo
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add onPrefixChange prop for detecting changes from selected prefix
Molecule/PhoneInput
🔍 Show
TASK:
Description, Motivation and Context
Types of changes