Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/atom/upload): Remove unnecesary width #2679

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

xaviermariaconejo
Copy link
Collaborator

Atom/Upload

🚢 Ship

Description, Motivation and Context

The Atom Upload has the icon with a weird aligment, because the component is invading the Icon that is inserted by prop

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles
  • 🛠️ Tool

Screenshots - Animations

BEFORE
Screenshot 2023-12-21 at 12 34 48
Screenshot 2023-12-21 at 12 35 02

AFTER (with changes applied)
Screenshot 2023-12-21 at 12 35 06
Screenshot 2023-12-21 at 12 35 14

Copy link

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0= ≍ 0= ≍ 0= ≍ 0=
% 76.17 63.55 65.72 77.93
ABS 3335 / 4378 1967 / 3095 648 / 986 3162 / 4057

@xaviermariaconejo xaviermariaconejo merged commit 3346c00 into master Dec 21, 2023
7 checks passed
@xaviermariaconejo xaviermariaconejo deleted the feat/align_problem_upload branch December 21, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants