Feat/add shape prop to select popover #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emiliovillu
requested review from
sui-bot,
kikoruiz,
andresin87 and
andresz1
as code owners
|
andresin87
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Molecule/Select-Popover
🔍 ShowTASK: MTR-85397 & MTR-86103
Description, Motivation and Context
Added
shapeproperty to the Select Popover component, because of a need in the new Engine filters. We have left the existing variable that defines the border radius, so that it remains backwards compatible with all vertical themes that are overwriting this variable$bdrs-select-popoverand that are not passing this new property.Types of changes