refactor(components/molecule/coachmark): Use div instead of p to wrap the step content #2752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
molecule/coachmark
🔍 Show
TASK:
Description, Motivation and Context
As you can see at the image below, currently we are wrapping the step content inside a
<p>
. It's not a good practice put inside a<p>
some extra HTML such as a<div>
for example. ThevalidateDOMNEsting
function is causing warning comments in our browser console or testing terminal.We have decided to change it with a
<div>
because make more sense in terms of HTML.Types of changes
Screenshots - Animations