Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components/molecule/coachmark): Use div instead of p to wrap the step content #2752

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

oriolpuig
Copy link
Collaborator

@oriolpuig oriolpuig commented Aug 2, 2024

molecule/coachmark

🔍 Show

TASK:

Description, Motivation and Context

As you can see at the image below, currently we are wrapping the step content inside a <p>. It's not a good practice put inside a <p> some extra HTML such as a <div> for example. The validateDOMNEsting function is causing warning comments in our browser console or testing terminal.

We have decided to change it with a <div> because make more sense in terms of HTML.

Types of changes

  • 🧠 Refactor

Screenshots - Animations

image

@oriolpuig oriolpuig changed the title refactor(components/molecule/coachmark): Use div instead of p to wrap… refactor(components/molecule/coachmark): Use div instead of p to wrap the step content Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0= ≍ 0= ≍ 0= ≍ 0=
% 75.9 64.19 65.99 77.7
ABS 3343 / 4404 2051 / 3195 654 / 991 3164 / 4072

@oriolpuig oriolpuig marked this pull request as ready for review August 2, 2024 11:57
Copy link

github-actions bot commented Aug 6, 2024

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0= ≍ 0= ≍ 0= ≍ 0=
% 75.9 64.19 65.99 77.7
ABS 3343 / 4404 2051 / 3195 654 / 991 3164 / 4072

@andresin87 andresin87 merged commit b7e6975 into master Aug 6, 2024
7 checks passed
@andresin87 andresin87 deleted the refactor/molecule_coachmark_content_wrapper branch August 6, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants