Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/molecule/stepper): add label to each step a11y #2757

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

andresin87
Copy link
Member

Molecule/Stepper

πŸ” Show

TASK:

Description, Motivation and Context

Types of changes

  • πŸͺ² Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • πŸ“· Demo
  • πŸ§ͺ Test
  • 🧠 Refactor
  • πŸ’„ Styles
  • πŸ› οΈ Tool

Screenshots - Animations

@@ -29,10 +29,12 @@ const DefaultStep = ({
})
return (
<>
<div className={cx(`${BASE_CLASS_STEP}Icon`)}>{resultingIcon}</div>
{showLabel && (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️

Copy link

github-actions bot commented Sep 9, 2024

STATEMENTS BRANCHES FUNCTIONS LINES
≍ ≍ 0.01↑ ≍ 0.05↓ ≍ 0= ≍ 0=
% 75.91 64.14 65.99 77.71
ABS 3345 / 4406 2047 / 3191 654 / 991 3167 / 4075

Copy link
Collaborator

@oriolpuig oriolpuig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ₯’ ❀️

@andresin87 andresin87 merged commit 9a676ac into master Sep 9, 2024
7 checks passed
@andresin87 andresin87 deleted the stepper-label-a11y branch September 9, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants