feat(components/molecule/photoUploader): add prop onSortPhotoStart to… #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmartin84
requested review from
sui-bot,
kikoruiz,
andresin87 and
andresz1
as code owners
|
jordevo
reviewed
Oct 17, 2024
Comment on lines
+525
to
+526
| /** Func to be executed when photo is being sorted */ | ||
| onSortPhotoStart: PropTypes.func, |
There was a problem hiding this comment.
🍆 not sure then what does Start mean there...? is it because the event fires when the user "starts" sorting photos? should we aim for some more simple naming ie onSortPhotos or something like that?
There was a problem hiding this comment.
oh I see it's coupled to the name the ReactSortable component prop has... onStart
There was a problem hiding this comment.
still, I would keep it simple... onSortPhotos is my suggestion 😉
davidmartin84
deleted the
feature/add-on-start-drag-photo-photouploader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… photouploader
Category/Component
TASK:
Description, Motivation and Context
Types of changes
Screenshots - Animations