Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/molecule/dropdownOption): improve design when description and left addon exists #2772

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

codemaoz90
Copy link
Collaborator

@codemaoz90 codemaoz90 commented Oct 22, 2024

Category/Component

TASK:

Description, Motivation and Context

When using the description and leftAddon props together, the current layout does not render as expected. This PR addresses a design requirement to improve the alignment and display of both elements, ensuring they appear correctly when used in combination.

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles
  • 🛠️ Tool

Screenshots - Animations

BEFORE:
image

image

@codemaoz90 codemaoz90 changed the title feat(components/molecule/dropdownOption): improve design when descrip… feat(components/molecule/dropdownOption): improve design when description and left addon exists Oct 22, 2024
Copy link

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0.01↑ ≍ 0.02↑ ≍ 0= ≍ 0=
% 75.92 64.06 65.76 77.7
ABS 3362 / 4428 2059 / 3214 657 / 999 3183 / 4096

@codemaoz90 codemaoz90 merged commit fb18e51 into master Oct 23, 2024
7 checks passed
@codemaoz90 codemaoz90 deleted the feat/allow-description-with-addon branch October 23, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants