Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/molecule/carousel): suggest use of new colour token variables #2774

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

jordevo
Copy link
Contributor

@jordevo jordevo commented Oct 29, 2024

molecule/carousel

Description, Motivation and Context

Since $c-background and $c-transparent are too broad to be used for the purposes they're being used here, I suggest using more specific variables so we don't have conflicts in case a $c-background variable is already in use on the theme and we want to keep a different background colour for the component, for instance, or we want to specify a different tap highlight colour.

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles
  • 🛠️ Tool

Screenshots - Animations

Copy link

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0= ≍ 0= ≍ 0= ≍ 0=
% 75.92 64.06 65.76 77.7
ABS 3362 / 4428 2059 / 3214 657 / 999 3183 / 4096

@jordevo jordevo merged commit a7bb4f2 into master Oct 29, 2024
7 checks passed
@jordevo jordevo deleted the feat-molecule-carousel-adjust-tokens branch October 29, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants