feat(components/molecule/carousel): suggest use of new colour token variables #2774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
molecule/carousel
Description, Motivation and Context
Since
$c-background
and$c-transparent
are too broad to be used for the purposes they're being used here, I suggest using more specific variables so we don't have conflicts in case a$c-background
variable is already in use on the theme and we want to keep a different background colour for the component, for instance, or we want to specify a different tap highlight colour.Types of changes
Screenshots - Animations