Merge pull request #1846 from SUI-Components/feat/sui-logger

refactor(packages/sui-logger): add missed Trackers in client and server level
SUI-Components · Oct 15, 2024 · 0cf7fa0 · 0cf7fa0
2 parents 67647e8 + 4106c99
commit 0cf7fa0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/packages/sui-logger/src/client.js b/packages/sui-logger/src/client.js
@@ -1,7 +1,8 @@
 import createLogger from './logger'
 
-export const createClientLogger = ({userId, trackerName} = {}) =>
+export const createClientLogger = ({Trackers, userId, trackerName} = {}) =>
   createLogger({
+    Trackers,
     listenUnhandled: logError => {
       const handleWindowError = e => {
         const error = e.reason || e.error

diff --git a/packages/sui-logger/src/server.js b/packages/sui-logger/src/server.js
@@ -31,8 +31,9 @@ const extractFrom = req => {
   }
 }
 
-export const logErrorsMiddleware = (error, req, res, next) => {
+export const logErrorsMiddleware = (Trackers, error, req, res, next) => {
   const logger = createLogger({
+    Trackers,
     ...extractFrom(req),
     forwardConsoleErrors: false
   })

diff --git a/packages/sui-logger/test/server/indexSpec.js b/packages/sui-logger/test/server/indexSpec.js
@@ -68,22 +68,27 @@ describe('initTracker', () => {
 describe('logsErrorsMiddleware', () => {
   let logger
   let loggerPkgStub
+  let trackerStub
+  let TrackersCreateStub
 
   before(() => {
     logger = {error: sinon.stub()}
     loggerPkgStub = sinon.stub(loggerPkg, 'default').returns(logger)
+    trackerStub = {emit: sinon.stub()}
+    TrackersCreateStub = sinon.stub(Trackers, 'create').returns(trackerStub)
   })
 
   after(() => {
     loggerPkgStub.restore()
+    TrackersCreateStub.restore()
   })
 
   it('log the error and pass execution to next middleware', () => {
     const error = 'Error Message'
     const req = {headers: {}, url: '/'}
     const res = null
     const next = sinon.stub()
-    server.logErrorsMiddleware(error, req, res, next)
+    server.logErrorsMiddleware(trackerStub, error, req, res, next)
 
     expect(logger.error.calledWith(error)).to.equal(true)
     expect(next.calledWith(error)).to.equal(true)