feat(packages/sui-react-web-vitals): add presentationTime comment

SUI-Components · Nov 24, 2023 · 3aaee12 · 3aaee12
1 parent 55f1eaf
commit 3aaee12
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/packages/sui-react-web-vitals/src/index.js b/packages/sui-react-web-vitals/src/index.js
@@ -81,6 +81,9 @@ export default function WebVitalsReporter({
     }
 
     const computeINPMetrics = entry => {
+      // RenderTime is an estimate because duration is rounded and may get rounded down.
+      // In rare cases, it can be less than processingEnd and that breaks performance.measure().
+      // Let's ensure it's at least 4ms in those cases so you can barely see it.
       const presentationTime = Math.max(entry.processingEnd + 4, entry.startTime + entry.duration)
 
       return {