feat(packages/sui-segment-wrapper): modify set method

SUI-Components · Oct 21, 2024 · cf37a8e · cf37a8e
1 parent 1184d81
commit cf37a8e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/packages/sui-segment-wrapper/src/repositories/googleRepository.js b/packages/sui-segment-wrapper/src/repositories/googleRepository.js
@@ -53,12 +53,10 @@ const getGoogleField = async field => {
 export const getGoogleClientID = () => getGoogleField(FIELDS.clientId)
 export const getGoogleSessionID = () => getGoogleField(FIELDS.sessionId)
 
-export const sendGoogleUserId = userId => {
+export const setGoogleUserId = userId => {
   const googleAnalyticsMeasurementId = getConfig('googleAnalyticsMeasurementId')
 
   if (!googleAnalyticsMeasurementId || !userId) return
 
-  window.gtag?.('set', googleAnalyticsMeasurementId, {
-    user_id: userId
-  })
+  window.gtag?.('set', 'user_id', userId)
 }
diff --git a/packages/sui-segment-wrapper/src/segmentWrapper.js b/packages/sui-segment-wrapper/src/segmentWrapper.js
@@ -1,7 +1,7 @@
 // @ts-check
 
 import {getAdobeMCVisitorID} from './repositories/adobeRepository.js'
-import {getGoogleClientID, getGoogleSessionID, sendGoogleUserId} from './repositories/googleRepository.js'
+import {getGoogleClientID, getGoogleSessionID, setGoogleUserId} from './repositories/googleRepository.js'
 import {getConfig} from './config.js'
 import {checkAnalyticsGdprIsAccepted, getGdprPrivacyValue} from './tcf.js'
 import {getXandrId} from './repositories/xandrRepository.js'
@@ -208,7 +208,7 @@ const track = (event, properties, context = {}, callback) =>
 const identify = async (userId, traits, options, callback) => {
   const gdprPrivacyValue = await getGdprPrivacyValue()
 
-  sendGoogleUserId(userId)
+  setGoogleUserId(userId)
 
   return window.analytics.identify(
     userId,

diff --git a/packages/sui-segment-wrapper/test/stubs.js b/packages/sui-segment-wrapper/test/stubs.js
@@ -48,15 +48,13 @@ export const stubGoogleAnalytics = () => {
     session_id: 'fakeSessionId'
   }
 
-  window.gtag = (key, id, fieldName, done) => {
+  window.gtag = (key, id, field, done) => {
     if (key === 'get') {
-      return done(savedFields?.[fieldName])
+      return done(savedFields?.[field])
     }
 
-    if (key === 'set' && typeof fieldName === 'object') {
-      Object.keys(fieldName).forEach(field => {
-        savedFields[field] = fieldName[field]
-      })
+    if (key === 'set') {
+      savedFields[id] = field
     }
   }
 }