[FEAT] sync typescript versions #1613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikoruiz
commented
Jun 26, 2023
packages/sui-mock/package.json
Outdated
| @@ -1,13 +1,13 @@ | |||
| { | |||
| "name": "@s-ui/mock", | |||
| "version": "1.2.0", | |||
| "version": "1.3.0-beta.3", | |||
There was a problem hiding this comment.
Will be removed before merging.
kikoruiz
commented
Jun 26, 2023
| @@ -61,7 +61,7 @@ export const writerFactory = providers => (path, data) => { | |||
| }) | |||
|
|
|||
| console.log(`Writing the Pact file "${path}"`) // eslint-disable-line | |||
| writeData2File(path, data) | |||
| createWriter()(path, data) | |||
There was a problem hiding this comment.
Fix for a breaking change introduced in v1.4.0: pactflow/pact-msw-adapter@6d45541
carlosvillu
approved these changes
Jun 26, 2023
kikoruiz
commented
Oct 16, 2023
| "@pactflow/pact-msw-adapter": "1.2.1", | ||
| "@s-ui/mock": "1", | ||
| "@pactflow/pact-msw-adapter": "1.5.0", | ||
| "@s-ui/mock": "beta", |
There was a problem hiding this comment.
We'll change it when the new sui-mock version is released in the next master workflow execution.
andresz1
approved these changes
Oct 16, 2023
nucliweb
approved these changes
Oct 16, 2023
carlosvillu
approved these changes
Oct 16, 2023
jordevo
approved these changes
Oct 16, 2023
|
It won't be fixed here, it will be done in: #1614 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync all the TypeScript versions along our SUI tools.