Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages/sui-ssr): revert csp report #1650

Merged
merged 2 commits into from
Oct 19, 2023
Merged

feat(packages/sui-ssr): revert csp report #1650

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c024ba
feat(packages/sui-ssr): revert csp report
carlosvillu Oct 19, 2023
7ddc4e5
refactor(packages/sui-ssr): fix linter
carlosvillu Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/sui-ssr/server/middlewares/ssr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
const HEAD_OPENING_TAG = '<head>'
const HEAD_CLOSING_TAG = '</head>'

const CSP_REPORT_PATH = '/csp-report'

Check failure on line 40 in packages/sui-ssr/server/middlewares/ssr.js

View workflow job for this annotation

GitHub Actions / build 

'CSP_REPORT_PATH' is assigned a value but never used. Allowed unused vars must match /React/u

const formatServerTimingHeader = metrics =>
Object.entries(metrics)
Expand Down Expand Up @@ -208,8 +208,8 @@
'Server-Timing': formatServerTimingHeader({
...performance,
...ssrPerformance
}),
'Content-Security-Policy-Report-Only': `default-src 'self'; report-uri ${CSP_REPORT_PATH}`
})
// 'Content-Security-Policy-Report-Only': `default-src 'self'; report-uri ${CSP_REPORT_PATH}`
})
res.write(HtmlBuilder.buildHead({headTplPart, headString, htmlAttributes}))
res.flush()
Expand Down
Loading