Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages/sui-jest): Allow test server& browser environments #1655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/sui-jest/bin/config.js

This file was deleted.

29 changes: 29 additions & 0 deletions packages/sui-jest/bin/sui-jest-browser.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
#!/usr/bin/env node
/* eslint-disable no-console */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed ?

const program = require('commander')
const runner = require('../src/runner.js')

// Setup default env vars
process.env.BABEL_ENV = 'test'
process.env.NODE_ENV = 'test'

program
.option('-W, --watch', 'Run in watch mode')
.option('--ci', 'Run a Firefox headless for CI testing')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a plural version for Firefox. This should be one of the following:

1 - Run a Firefox headless browser for CI testing
2 - Run Firefox in headless mode for CI testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I should check/update this description in order this is wrong I guess. Thanks again for detect it!

.option('-P, --pattern <pattern>', 'Path pattern to include', false)
.option('-c, --coverage', 'Run the coverage preprocessor', false)
.on('--help', () => {
console.log(' Description:')
console.log('')
console.log(' Run tests in browser with Jest')
console.log('')
console.log(' Examples:')
console.log('')
console.log(' $ sui-jest browser')
console.log('')
})
.parse(process.argv)

const {ci, coverage, pattern, watch} = program.opts()

runner({ci, coverage, environment: 'jsdom', pattern, watch})
29 changes: 29 additions & 0 deletions packages/sui-jest/bin/sui-jest-server.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
#!/usr/bin/env node
/* eslint-disable no-console */
const program = require('commander')
const runner = require('../src/runner.js')

// Setup default env vars
process.env.BABEL_ENV = 'test'
process.env.NODE_ENV = 'test'

program
.option('-W, --watch', 'Run in watch mode')
.option('--ci', 'Run a Firefox headless for CI testing')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment for the Firefox pluralisation also applies here

.option('-P, --pattern <pattern>', 'Path pattern to include', false)
.option('-c, --coverage', 'Run the coverage preprocessor', false)
.on('--help', () => {
console.log(' Description:')
console.log('')
console.log(' Run tests in server with Jest')
console.log('')
console.log(' Examples:')
console.log('')
console.log(' $ sui-jest server')
console.log('')
})
.parse(process.argv)

const {ci, coverage, pattern, watch} = program.opts()

runner({ci, coverage, environment: 'node', pattern, watch})
17 changes: 10 additions & 7 deletions packages/sui-jest/bin/sui-jest.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
#!/usr/bin/env node
const {hasFile} = require('./utils.js')
const program = require('commander')

// Setup default env vars
process.env.BABEL_ENV = 'test'
process.env.NODE_ENV = 'test'

const args = process.argv.slice(2)
const pkg = require('../package.json')
const version = pkg.version

const config =
!args.includes('--config') && !hasFile('jest.config.js')
? ['--config', JSON.stringify(require('./config.js'))]
: []
program.version(version, ' --version')

require('jest').run([...config, ...args])
program.command('browser', 'Run tests in the browser').alias('b')

program.command('server', 'Run tests in node').alias('s')

program.parse(process.argv)
15 changes: 15 additions & 0 deletions packages/sui-jest/src/config/jest.browser.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/**
* For a detailed explanation regarding each configuration property, visit:
* https://jestjs.io/docs/configuration
*/

// TODO: add sui jest common config
const jestConfig = {
testMatch: [
'**/__tests__/**/suite/**/?(*.)+(test).+(ts|tsx|js|jsx)',
'**/__tests__/**/*.(client|browser)+.*.(ts|tsx|js|jsx)',
'!**/__tests__/**/*server*'
]
}

module.exports = jestConfig
197 changes: 197 additions & 0 deletions packages/sui-jest/src/config/jest.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,197 @@
/**
* For a detailed explanation regarding each configuration property, visit:
* https://jestjs.io/docs/configuration
*/

// TODO: Decide which is the default common config
const jestConfig = {
// All imported modules in your tests should be mocked automatically
Copy link
Collaborator

@danilucaci danilucaci Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove all the commented options if they are not used. We can always read the official docs for the available API.

// automock: false,

// Stop running tests after `n` failures
// bail: 0,

// The directory where Jest should store its cached dependency information
// cacheDirectory: "/private/var/folders/r5/sfgw__110f9dggbdy8v_l_kc0000gq/T/jest_dz",

// Automatically clear mock calls, instances, contexts and results before every test
clearMocks: true,

// Indicates whether the coverage information should be collected while executing the test
collectCoverage: false,

// An array of glob patterns indicating a set of files for which coverage information should be collected
// collectCoverageFrom: undefined,

// The directory where Jest should output its coverage files
coverageDirectory: 'coverage',

// An array of regexp pattern strings used to skip coverage collection
// coveragePathIgnorePatterns: [
// "/node_modules/"
// ],

// Indicates which provider should be used to instrument code for coverage
coverageProvider: 'v8',

// A list of reporter names that Jest uses when writing coverage reports
// coverageReporters: [
// "json",
// "text",
// "lcov",
// "clover"
// ],

// An object that configures minimum threshold enforcement for coverage results
// coverageThreshold: undefined,

// A path to a custom dependency extractor
// dependencyExtractor: undefined,

// Make calling deprecated APIs throw helpful error messages
// errorOnDeprecated: false,

// The default configuration for fake timers
// fakeTimers: {
// "enableGlobally": false
// },

// Force coverage collection from ignored files using an array of glob patterns
// forceCoverageMatch: [],

// A path to a module which exports an async function that is triggered once before all test suites
// globalSetup: undefined,

// A path to a module which exports an async function that is triggered once after all test suites
// globalTeardown: undefined,

// A set of global variables that need to be available in all test environments
// globals: {},

// The maximum amount of workers used to run your tests. Can be specified as % or a number. E.g. maxWorkers: 10% will use 10% of your CPU amount + 1 as the maximum worker number. maxWorkers: 2 will use a maximum of 2 workers.
// maxWorkers: "50%",

// An array of directory names to be searched recursively up from the requiring module's location
// moduleDirectories: [
// "node_modules"
// ],

// An array of file extensions your modules use
// moduleFileExtensions: [
// "js",
// "mjs",
// "cjs",
// "jsx",
// "ts",
// "tsx",
// "json",
// "node"
// ],

// A map from regular expressions to module names or to arrays of module names that allow to stub out resources with a single module
// moduleNameMapper: {},

// An array of regexp pattern strings, matched against all module paths before considered 'visible' to the module loader
// modulePathIgnorePatterns: [],

// Activates notifications for test results
// notify: false,

// An enum that specifies notification mode. Requires { notify: true }
// notifyMode: "failure-change",

// A preset that is used as a base for Jest's configuration
// preset: undefined,

// Run tests from one or more projects
// projects: undefined,

// Use this configuration option to add custom reporters to Jest
// reporters: undefined,

// Automatically reset mock state before every test
// resetMocks: false,

// Reset the module registry before running each individual test
// resetModules: false,

// A path to a custom resolver
// resolver: undefined,

// Automatically restore mock state and implementation before every test
// restoreMocks: false,

// The root directory that Jest should scan for tests and modules within
// rootDir: undefined,

// A list of paths to directories that Jest should use to search for files in
// roots: [
// "<rootDir>"
// ],

// Allows you to use a custom runner instead of Jest's default test runner
// runner: "jest-runner",

// The paths to modules that run some code to configure or set up the testing environment before each test
// setupFiles: [],

// A list of paths to modules that run some code to configure or set up the testing framework before each test
// setupFilesAfterEnv: [],

// The number of seconds after which a test is considered as slow and reported as such in the results.
// slowTestThreshold: 5,

// A list of paths to snapshot serializer modules Jest should use for snapshot testing
// snapshotSerializers: [],

// The test environment that will be used for testing
// testEnvironment: "jest-environment-node",

// Options that will be passed to the testEnvironment
// testEnvironmentOptions: {},

// Adds a location field to test results
// testLocationInResults: false,

// The glob patterns Jest uses to detect test files
// testMatch: ['!**/__tests__/**/*.[jt]s?(x)', '**/?(*.)+(spec|test).[tj]s?(x)'],
testMatch: ['**/__tests__/**/?(*.)+(spec|test).[tj]s?(x)'],
// An array of regexp pattern strings that are matched against all test paths, matched tests are skipped
// testPathIgnorePatterns: [
// "/node_modules/"
// ],

// The regexp pattern or array of patterns that Jest uses to detect test files
// testRegex: [],

// This option allows the use of a custom results processor
// testResultsProcessor: undefined,

// This option allows use of a custom test runner
// testRunner: "jest-circus/runner",

// A map from regular expressions to paths to transformers
transform: {
'^.+\\.(t|j)sx?$': '@swc/jest'
}

// An array of regexp pattern strings that are matched against all source file paths, matched files will skip transformation
// transformIgnorePatterns: [
// "/node_modules/",
// "\\.pnp\\.[^\\/]+$"
// ],

// An array of regexp pattern strings that are matched against all modules before the module loader will automatically return a mock for them
// unmockedModulePathPatterns: undefined,

// Indicates whether each individual test should be reported during the run
// verbose: undefined,

// An array of regexp patterns that are matched against all source file paths before re-running tests in watch mode
// watchPathIgnorePatterns: [],

// Whether to use watchman for file crawling
// watchman: true,
}

module.exports = jestConfig
15 changes: 15 additions & 0 deletions packages/sui-jest/src/config/jest.server.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/**
* For a detailed explanation regarding each configuration property, visit:
* https://jestjs.io/docs/configuration
*/

// TODO: add sui jest common config
const jestConfig = {
testMatch: [
'**/__tests__/**/suite/**/?(*.)+(test).+(ts|tsx|js|jsx)',
'**/__tests__/**/*.(server)+.*.(ts|tsx|js|jsx)',
'!**/__tests__/**/*{client|browser}*'
]
}

module.exports = jestConfig
38 changes: 38 additions & 0 deletions packages/sui-jest/src/runner.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
const defaultConfig = require('./config/jest.config.js')
const defaultServerConfig = require('./config/jest.server.config.js')
const defaultBrowserConfig = require('./config/jest.browser.config.js')
const {hasFile, fromRoot} = require('./utils/index.js')

const JEST_CONFIG_FILE_NAME = 'jest.config.js'

module.exports = async ({ci, coverage, environment, watch, pattern}) => {
const args = []
let config = defaultConfig

if (ci) args.push('--ci')
if (coverage) args.push('--coverage')
if (environment) args.push(...['--env', environment])
if (pattern) defaultConfig.testMatch = [pattern]
if (watch) args.push('--watch')

// Add server support
if (environment === 'node') {
config = {...config, ...defaultServerConfig}
}

// Add browser support
if (environment === 'jsdom') {
config = {...config, ...defaultBrowserConfig}
}

// If project has a jest.config.js file, we merge it with the default one
if (hasFile(JEST_CONFIG_FILE_NAME)) {
const projectJestConfigPath = fromRoot(JEST_CONFIG_FILE_NAME)
const projectJestConfig = require(projectJestConfigPath)
config = {...config, ...projectJestConfig}
}

args.push(...['--config', JSON.stringify(config)])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to create a temporary array for the spread operation. [].push(arg1, arg2, arg3) works with comma separated arguments.


require('jest').run([...args])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use only require('jest').run(args)? There is no need for the temporary array that is used for the spread operation. The args array is also available only inside the scope of the function, therefore, it can't be modified globally.

}
File renamed without changes.