Create Adevinta Eslint rules #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosvillu
requested review from
sui-bot,
kikoruiz and
andresz1
as code owners
…nt-preset-sui rules
Create a custom test runner following the ESLint API
kikoruiz
reviewed
Mar 5, 2024
kikoruiz
approved these changes
Mar 5, 2024
kikoruiz
reviewed
Mar 5, 2024
Co-authored-by: Kiko Ruiz Lloret <[email protected]>
add url to aggrements
…ect TS or JS eslint config
…to sui-lint-adv-rules
kikoruiz
approved these changes
Mar 21, 2024
nucliweb
reviewed
Mar 21, 2024
nucliweb
reviewed
Mar 21, 2024
nucliweb
reviewed
Mar 21, 2024
nucliweb
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we are looking to lay the groundwork to be able to do two things:
Bring to Linter rules all the agreements in the domain. We are doing this both with new ESLint rules and with a new package that will allow us to lint the repositories, the files they contain and the structures.
Monitoring both the failures in the code agreements (Eslint) and in the agreements at repository level (LinterRepository). Sending the necessary information to be able to generate in DD a dashboard that gives us a status of the monitoring of the agreements by team.
Example