feat(packages/eslint-plugin-sui): Add rule to check relative imports #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
carlosvillu
commented
May 7, 2024
•
carlosvillu
commented
- Avoid relative imports between the monorepo packages.
- Sass files
- migration from JS to TS
- component outside of the Studio
- Spark adoption
* Really use the class as singleton * avoid missleading warning when the relative import is for the same package
…x? has the repository migrated
…nent here is in the app
nucliweb
reviewed
May 9, 2024
nucliweb
approved these changes
May 9, 2024
Co-authored-by: Joan León <[email protected]>
kikoruiz
approved these changes
May 10, 2024
andresin87
reviewed
May 13, 2024
| .filter(line => line.match(/'@spark-ui\/.*'/)).length | ||
|
|
||
| let percentage = (totalSparkComponents * 100) / (totalSparkComponents + totalSUIComponents) | ||
| percentage = Math.round((percentage + Number.EPSILON) * 100) / 100 |
jordevo
reviewed
May 13, 2024
| const resolvedBabelPresetSui = require.resolve('babel-preset-sui') | ||
| const parser = require.resolve('@babel/eslint-parser') | ||
|
|
||
| const CWD = '/Users/carlosvillu/Developer/frontend-mt--web-app' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.