Fix/interpolate with multiple nesting keys #1801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The interpolate function is using a statefull regex but it is being reused without reseting its inner state, in order to handle its statefull nature we need to reset the inner state lastIndex every time we need to reuse it to match something from the beginning.
Example
I found the bug by providing this literal: %[item1]Para verificar tu perfil, por favor revisa el email que te hemos enviado a: %[email][email]%.[item1]%%[item2]¿Este no es tu email? %[changeEmail]Cámbialo ahora[changeEmail]%.[item2]%%[item3]¿No lo has recibido? Revisa tu carpeta de spam o añade [email protected] a remitentes seguros.[item3]%%[item4]¿Aún no lo has recibido? %[resend]Te lo reenviamos[resend]%[item4]%
It was handling correctly the first and third nested elements but the second was not able to handle it due to the use of global regex