Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages/sui-logger): Add tracing to 300x and 400x pages #1886

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(packages/sui-logger): Add tracing to 300x and 400x pages #1886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sui-logger/src/server/expressMiddleware/DataDogLogger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class DataDogLogger extends Writable {
method: req ? req.method : '-' // eslint-disable-line
}

if (!req || statusFamily === '4xx' || statusFamily === '3xx') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know the reason why these status code families were an exception in the first place...?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as @carlosvillu and @andresz1 told me, the reason should be the increase of tags.

Adding this PR we will increase the number of tags for the server.request metric as much as routerUrls we have in the project ( x2, one for 3xx and the other for 4xx) In fotocasa for example it means add 80 tags

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand we get the option to monitor increases/decreases (anomalies) of 3xx and 4xx.
For example, that days we cannot create a monitor to detect an increase of 400x errors for a specific page. Only global

if (!req) {
this._client.timing('http.server.requests', duration, globalTags)
chunk = null
globalTags = null
Expand Down
Loading