Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark more images as singleton image #2302

Merged
merged 6 commits into from
Feb 24, 2025
Merged

mark more images as singleton image #2302

merged 6 commits into from
Feb 24, 2025
+6 −1

Conversation

dirkmueller
Copy link
Member

No description provided.

@dirkmueller
Fix build_name for singleton images
78f4fb4 
We were actually not stripping the version, which led to unstable
buildnames and a ton of aggregate updates all the time.
@dirkmueller dirkmueller changed the title Single images mark more images as singleton image Feb 20, 2025
dcermak pushed a commit that referenced this pull request Feb 20, 2025
Test build for #2302
5eee7a8
dcermak pushed a commit that referenced this pull request Feb 20, 2025
Test build for #2302
6a0bd92
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-2302
Changes pushed to branch 7-2302 as commit 29543fb125effd45f53c88085bf8993d6d849fc8
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2302 for x86_64: current state: published
Build results:

package name status build log
git-image ⛔ excluded live log
helm-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
rmt-server-image ⛔ excluded live log
spack-image ⛔ excluded live log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2302 for aarch64: current state: published
Build results:

package name status build log
git-image ⛔ excluded live log
helm-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
rmt-server-image ⛔ excluded live log
spack-image ⛔ excluded live log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2302 for s390x: current state: published
Build results:

package name status build log
git-image ⛔ excluded live log
helm-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
rmt-server-image ⛔ excluded live log
spack-image ⛔ excluded live log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2302 for ppc64le: current state: published
Build results:

package name status build log
git-image ⛔ excluded live log
helm-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
rmt-server-image ⛔ excluded live log
spack-image ⛔ excluded live log
stunnel-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2302 for x86_64: current state: published
Build results:

package name status build log
git-image ✅ succeeded live log
helm-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
rmt-server-image ✅ succeeded live log
spack-image ✅ succeeded live log
stunnel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2302 for aarch64: current state: published
Build results:

package name status build log
git-image ✅ succeeded live log
helm-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
rmt-server-image ✅ succeeded live log
spack-image ✅ succeeded live log
stunnel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2302 for s390x: current state: published
Build results:

package name status build log
git-image ✅ succeeded live log
helm-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
rmt-server-image ✅ succeeded live log
spack-image ⛔ excluded live log
stunnel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2302 for ppc64le: current state: published
Build results:

package name status build log
git-image ✅ succeeded live log
helm-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
rmt-server-image ✅ succeeded live log
spack-image ⛔ excluded live log
stunnel-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.7 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2302/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2302/containerfile/bci/kiwi:9
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2302/containerfile/bci/spack:0.23
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2302/containerfile/suse/git:2
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2302/containerfile/suse/helm:3
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2302/containerfile/suse/rmt-server:2
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2302/containerfile/suse/stunnel:5

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-2302
Changes pushed to branch 6-2302 as commit 9933159837ce1c0ee9028f1d8359614bb505c679
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2302 for x86_64: current state: published
Build results:

package name status build log
git-image ⛔ excluded live log
helm-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
rmt-server-image ⛔ excluded live log
spack-image ⛔ excluded live log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2302 for aarch64: current state: published
Build results:

package name status build log
git-image ⛔ excluded live log
helm-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
rmt-server-image ⛔ excluded live log
spack-image ⛔ excluded live log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2302 for s390x: current state: published
Build results:

package name status build log
git-image ⛔ excluded live log
helm-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
rmt-server-image ⛔ excluded live log
spack-image ⛔ excluded live log
stunnel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2302 for ppc64le: current state: published
Build results:

package name status build log
git-image ⛔ excluded live log
helm-image ⛔ excluded live log
kiwi-image ⛔ excluded live log
rmt-server-image ⛔ excluded live log
spack-image ⛔ excluded live log
stunnel-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2302 for x86_64: current state: publishing
Build results:

package name status build log
git-image ✅ succeeded live log
helm-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
rmt-server-image ✅ succeeded live log
spack-image ✅ succeeded live log
stunnel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2302 for aarch64: current state: publishing
Build results:

package name status build log
git-image ✅ succeeded live log
helm-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
rmt-server-image ✅ succeeded live log
spack-image ✅ succeeded live log
stunnel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2302 for s390x: current state: publishing
Build results:

package name status build log
git-image ✅ succeeded live log
helm-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
rmt-server-image ✅ succeeded live log
spack-image ⛔ excluded live log
stunnel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2302 for ppc64le: current state: publishing
Build results:

package name status build log
git-image ✅ succeeded live log
helm-image ✅ succeeded live log
kiwi-image ✅ succeeded live log
rmt-server-image ✅ succeeded live log
spack-image ⛔ excluded live log
stunnel-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2302/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2302/containerfile/bci/kiwi:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2302/containerfile/bci/spack:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2302/containerfile/suse/git:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2302/containerfile/suse/helm:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2302/containerfile/suse/rmt-server:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2302/containerfile/suse/stunnel:latest

@dirkmueller
Mark Helm as singleton image
81ec900 
We lost a couple of months of image updates because the aggregates
were not updated. Lets have a stable buildname to avoid this going
forward.
@dirkmueller
Mark Spack as singleton image
e48991c
@dirkmueller
Mark git as singleton image
227b048
@dirkmueller
Mark stunnel as singleton image
a51647f
@dirkmueller
Mark Kiwi as singleton image
48c21f5
dcermak pushed a commit that referenced this pull request Feb 20, 2025
Test build for #2302
e178fbc
dcermak pushed a commit that referenced this pull request Feb 20, 2025
Test build for #2302
29543fb
dcermak pushed a commit that referenced this pull request Feb 20, 2025
Test build for #2302
9933159
@github-actions GitHub Actions
Copy link

Created a staging project on OBS for 16.0: home:defolos:BCI:Staging:16.0:16.0-2302
Changes pushed to branch 16.0-2302 as commit e178fbc3bba365fc62247abec1db56ce719a5d98

@msmeissn
Copy link
Contributor

We have two different kiwi major versions between sle15 and sle16, would this work for that case?

Others might be single images, although I am not hundred percent sure spack will stay this way.

@dirkmueller
Copy link
Member Author

We have two different kiwi major versions between sle15 and sle16, would this work for that case?

Yes. we only need versions in the build name if the container is maintained in parallel from the same codestream, which isn't the case here.

Others might be single images, although I am not hundred percent sure spack will stay this way.

There is no harm with changing it to not be a singleton image anymore once that is the case. we'll have most pain with renaming the source package container (and the loss of build counter etc).

@dcermak dcermak merged commit 89e9698 into main Feb 24, 2025
7 of 8 checks passed
@dcermak dcermak deleted the single_images branch February 24, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcermak dcermak dcermak approved these changes

@alexandrevicenzi alexandrevicenzi Awaiting requested review from alexandrevicenzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirkmueller @msmeissn @dcermak