ci: fix tests and use SLE containers #94
Conversation
There was a problem hiding this comment.
I have to confess that I'm not a big fan of using git cloned versions, as it will become outdated at some point.
But hey, i don't have much suggestion except using zypper/leap, so up to you @yeoldegrove hehe
| # minimal python packages and compilers | ||
| zypper -n in -y python3-pip python3-devel gcc | ||
| # use current salt version shipped with SLE 15 | ||
| git clone --branch=openSUSE/release/3006.0 --depth=50 https://github.com/openSUSE/salt ../salt |
There was a problem hiding this comment.
I didn't remember this hacky thing we had before 😅
If we want to install salt using the same version shipped in SLE, why don't we use zypper?
This way, we would always have the latest rolling version I guess
There was a problem hiding this comment.
@arbulu89 Again, for Leap 42.3 there will be no updated anymore. Also for SLE 12.5 one needs to register an additional Module to install salt.
python-shaptools is also not available for Leap ...
I really would vote to use SLE. One could even think about building images before running the CI steps...
There was a problem hiding this comment.
What I forgot is that there also is some magic in tests/run.sh that uses stuff from the salt repo that is not delivered as rpm.
cp salt/modules/*.py ../salt/salt/modules/
cp salt/states/*.py ../salt/salt/states/
cp tests/unit/modules/*.py ../salt/tests/unit/modules/
cp tests/unit/states/*.py ../salt/tests/unit/states/
py.test -vv ../salt/tests/unit/modules/test_hanamod.py ../salt/tests/unit/states/test_hanamod.py ../salt/tests/unit/modules/test_crmshmod.py ../salt/tests/unit/modules/test_saptunemod.py ../salt/tests/unit/modules/test_sapcarmod.py ../salt/tests/unit/states/test_crmshmod.py ../salt/tests/unit/modules/test_drbdmod.py ../salt/tests/unit/states/test_drbdmod.py ../salt/tests/unit/states/test_saptunemod.py ../salt/tests/unit/modules/test_netweavermod.py ../salt/tests/unit/states/test_netweavermod.py ../salt/tests/unit/states/test_sapcarmod.py --cov=salt.modules.hanamod --cov=salt.states.hanamod --cov=salt.modules.crmshmod --cov=salt.states.crmshmod --cov=salt.modules.drbdmod --cov=salt.modules.saptunemod --cov=salt.modules.sapcarmod --cov=salt.states.saptunemod --cov=salt.states.drbdmod --cov=salt.modules.netweavermod --cov=salt.states.netweavermod --cov=salt.states.sapcarmod --cov-config .coveragerc --cov-report term --cov-report xml --cov-report html
There was a problem hiding this comment.
I pushed another commit that at least installs the packaged salt version. Had to do a little other change to tets/run.sh.
There was a problem hiding this comment.
You have my blessing @yeoldegrove XD
This salt versioning thing was already a pain in the *** hehe
This fixes the currently broken CI pipeline. Github actions/setup-python deprecated python 2.7 actions/setup-python#543 and is not usable anymore.
The SLE 15 SP5 tests will fail, as #93 still has to be fixed.