Skip to content
This repository has been archived by the owner on Feb 6, 2025. It is now read-only.

[WIP] update suggestions for add features in aws mutlti zone support #1325

Open
wants to merge 2,122 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
2122 commits
Select commit Hold shift + click to select a range
7ea4cd0
Select workers for daily jobs based on version (#1129)
Jun 2, 2020
7e0e1a3
Fix quotes in label to allow variable substitution
Jun 3, 2020
5c72f67
Merge pull request #1135 from pablochacin/fix-label-variable-substitu…
JanZerebecki Jun 3, 2020
5fcf6d0
Update k8s libraries
May 14, 2020
de56e32
Update certificates configuration ussage
May 14, 2020
8346223
Add context ussage to all client calls
May 14, 2020
8f7d820
refactor config defaulting for kubeadmn 1.18
May 26, 2020
3960d69
deletes config test, obsolete
May 29, 2020
d5ab203
validate error on function VerifyUnmarshalStrictC
May 29, 2020
afa4139
Require go version 1.13
cmurphy Mar 13, 2020
e5f4461
AutoYaST adapted for CaaSP 5 based on SLE-15-SP2
thehejik Jun 4, 2020
8b55cf1
Use Repository branch from ci-repo label (#1134)
Jun 5, 2020
33988a9
Create separated projects for v4 and v5 jobs (#1136)
Jun 8, 2020
4488172
Select worker type based on target branch for PR
May 28, 2020
8bd9a4a
Switch daily job version branches
Jun 8, 2020
3dc9fbc
Adapting terraform vars file for SLE15-SP2
davidcassany May 25, 2020
28710b4
Merge pull request #1130 from pablochacin/select-worker-for-target-brach
JanZerebecki Jun 8, 2020
e7a6079
Switch to v5 CR container images
dirkmueller Jun 7, 2020
199630c
Merge pull request #997 from cmurphy/go-1.13
davidcassany Jun 8, 2020
29c60bc
Merge pull request #1107 from chentex/upgrade-k8s-libraries
davidcassany Jun 8, 2020
e14f2d8
Merge pull request #1132 from davidcassany/initial_caasp_v5_tests
davidcassany Jun 8, 2020
7bcac54
Merge pull request #1138 from thehejik/master
jordimassaguerpla Jun 9, 2020
1c92dba
Merge pull request #1141 from pablochacin/switch-daily-jobs-branches
jordimassaguerpla Jun 9, 2020
db00ee3
Merge pull request #1140 from dirkmueller/experimental-v5
jordimassaguerpla Jun 9, 2020
4f78ffe
Collect logs from platform after e2e tests (#1142)
pablochacin Jun 9, 2020
3d57dc6
versions: Fix Cilium version for k8s v1.18.2
vadorovsky Jun 9, 2020
6fa2252
Merge pull request #1143 from mrostecki/fix-cilium-version
jordimassaguerpla Jun 9, 2020
b3a5710
versions: Fix Cilium version for k8s v1.18.2 (#1144)
pablochacin Jun 9, 2020
2d340d8
Merge pull request #1154 from SUSE/experimental-v5
jordimassaguerpla Jun 11, 2020
f33c43b
Fix typo in configuration comment
dirkmueller Jun 10, 2020
4b79888
Split daily execution in different time ranges
Jun 11, 2020
6829156
Run e2e test is dedicated workers
Jun 11, 2020
80cc890
Merge pull request #1156 from pablochacin/schedule-daily-by-version
jordimassaguerpla Jun 12, 2020
2068489
Remove pr-test-libvirt job (#1161)
pablochacin Jun 12, 2020
e6d5566
Fix duplicate name issues with secgroup handling
dirkmueller May 13, 2020
3b92553
Validate skuba cluster init input
evrardjp May 15, 2020
11984d9
Restrict cluster name to non-empty strings
evrardjp May 25, 2020
5c1124b
Fix pr-test pipeline in non pr branches (#1157)
pablochacin Jun 15, 2020
5731ff8
Merge pull request #1111 from evrardjp/no-empty-clustername
evrardjp Jun 15, 2020
d7d5bfe
Quick Fix: fix environment variable name in pr test (#1163)
pablochacin Jun 15, 2020
972d0a8
Support multiple target branches in pr rebase (#1158)
pablochacin Jun 15, 2020
9760deb
Set sonobouy version for each branch
Jun 15, 2020
60561e2
Remove checkout stage
Jun 16, 2020
377fd26
Fix log collection in pr pipeline (#1166)
pablochacin Jun 16, 2020
c162422
Merge pull request #1164 from pablochacin/update-sonobuoy-version
JanZerebecki Jun 16, 2020
ba59b9a
Fix version for repository branches
Jun 16, 2020
5ce3e27
Merge pull request #1149 from dirkmueller/crio_cleanup
JanZerebecki Jun 16, 2020
05bccf5
Merge pull request #1167 from pablochacin/update-branch-repo-version
JanZerebecki Jun 16, 2020
9c92012
review spec template for v5
jordimassaguerpla Jun 17, 2020
6a807bc
Merge pull request #1170 from jordimassaguerpla/switch_to_v5_in_pkg_spec
jordimassaguerpla Jun 17, 2020
b4a37bd
Update the staging constants
davidcassany Jun 17, 2020
aaa133b
Merge pull request #1171 from davidcassany/fix_staging_registry_constant
jordimassaguerpla Jun 17, 2020
9f6de2a
assets: Ensure BPFFS mount (bsc#1146991)
vadorovsky May 12, 2020
cc36786
Merge pull request #1101 from mrostecki/fix-bpffs-mount
evrardjp Jun 17, 2020
0ab09d8
Increase cilium's liveness/readiness probes timeout.
jvanz Jun 12, 2020
3a0f530
Bump cilium manifest version
jvanz Jun 15, 2020
990be01
Fix expected formatting for 1.14 (#1082)
evrardjp Jun 18, 2020
361b8bb
Update builder to 15.2 (#1075)
evrardjp Jun 18, 2020
74d64af
Refactor Init() function
Jun 11, 2020
ff7b032
add feature for azure terraform (#1496) (#1102)
Jun 18, 2020
9a4b4e9
Return err when there is a failure upgrading (#1056)
manuelbuil Jun 18, 2020
93a3518
Introduce special handling of CNI addons
Jun 12, 2020
8f7f7ad
Do not automatically classify stderr as err (#1030)
evrardjp Jun 19, 2020
e056767
activate 5 and not 4.0 product
jordimassaguerpla Jun 19, 2020
4ffe149
connect to 15.2 modules
jordimassaguerpla Jun 19, 2020
8177ac8
Merge pull request #1176 from SUSE/activate_5_product
jordimassaguerpla Jun 19, 2020
0409672
Fix the branched repo url
davidcassany Jun 19, 2020
74f429a
Add kucero addon to auto rotates control plane certificates (#1152)
Jun 22, 2020
3deb98b
Add node IP/FQDN after success join (#1175)
Jun 22, 2020
4768eef
Update release constants to v5
jordimassaguerpla Jun 22, 2020
68dee82
Update release_constants.go
jordimassaguerpla Jun 22, 2020
0519651
Merge pull request #1177 from davidcassany/fix_branched_repo_url
davidcassany Jun 22, 2020
9d92ffd
Merge pull request #1179 from SUSE/update_release_constants_to_v5
jordimassaguerpla Jun 22, 2020
c66fa4d
Implement manual e2e test job
Jun 22, 2020
f242490
Merge pull request #1160 from jvanz/cilium-timeout-liveness-probe
vadorovsky Jun 22, 2020
c171885
bsc#1171349 Inherit root disk format from template (#1093)
spiarh Jun 23, 2020
983a0e3
Flake8 fixes (#1151)
dirkmueller Jun 23, 2020
022183c
[terraform] fix mtu (#1181)
spiarh Jun 23, 2020
57c1cc9
Merge pull request #1180 from pablochacin/manual-e2e-job
pablochacin Jun 23, 2020
1967cc7
Merge pull request #1162 from rktidwell/master
manuelbuil Jun 23, 2020
ad7ab9a
Register kucero addon with generic type (#1186)
Jun 24, 2020
cbf4fb0
Support In-tree Azure Cloud Provider (#1148)
c3y1huang Jun 24, 2020
dc3ccc2
Single source of oidc client secret (bsc#1173055) (#1174)
Jun 24, 2020
c917a4a
Merge pull request #1106 from dirkmueller/master
evrardjp Jun 24, 2020
ba3f33a
Update cri-o runtime to version 1.18.2
mjura Jun 24, 2020
3e94bd2
Also deploy /etc/containers/registries.conf
JanZerebecki May 28, 2020
81f9ef7
testrunner: Add --registry-mirror
JanZerebecki Jun 4, 2020
8de8f9a
testrunner: Add config files to gather_logs
JanZerebecki Jun 18, 2020
f5ab628
Set image alternate mirror from ci-repo label
JanZerebecki Jun 23, 2020
8444947
Add notes on how to provision a default storage pool for use of libvirt
dirkmueller Jun 9, 2020
f8e5122
document which variable needs to match the default storage pool
dirkmueller Jun 16, 2020
0587be6
Update ci/infra/libvirt/README.md
dirkmueller Jun 23, 2020
9cbcedd
Merge pull request #1127 from JanZerebecki/test-branched-images
pablochacin Jun 25, 2020
ed50473
Merge pull request #1183 from JanZerebecki/image-branch-from-label
pablochacin Jun 25, 2020
17cc57b
replace tabs that should be spaces in README
JanZerebecki Jun 25, 2020
7ccfd90
Merge pull request #902 from manuelbuil/ssh_keys
davidcassany Jun 25, 2020
c873dbf
Quickfix: fix url to branch repository
Jun 25, 2020
b7af006
Merge pull request #1193 from pablochacin/fix-repo-version-e2e-test
davidcassany Jun 25, 2020
e4f8e33
Merge pull request #1194 from JanZerebecki/fix-spaces-README
JanZerebecki Jun 25, 2020
f3c1f27
Add image mirror to e2e test
Jun 25, 2020
d044045
QUICK FIX: fix image repositor url for mirrors
Jun 25, 2020
23ad12c
Merge pull request #1147 from dirkmueller/libvirt_readme
flavio Jun 25, 2020
6169fb7
Merge pull request #1195 from pablochacin/add-image-mirror-e2e-test
pablochacin Jun 25, 2020
9f0f126
Fix check for null environment variable
Jun 25, 2020
9cd2299
Merge pull request #1198 from pablochacin/fix-check-null-env-variable
pablochacin Jun 25, 2020
ff181ab
Merge pull request #1196 from pablochacin/fix-image-repository-url
dirkmueller Jun 25, 2020
456db7a
declare environment for all Jenkinsfile steps
JanZerebecki Jun 25, 2020
510b4cb
Merge pull request #1199 from JanZerebecki/fix-env-vars
pablochacin Jun 26, 2020
ab291ca
remove scm stage from pr pipeline
Jun 16, 2020
020fc26
Fix path to ci code
Jun 16, 2020
6bfaede
remove pr checks
Jun 16, 2020
4be9173
Replace COMMIT_ID for PR HEAD when setting status
Jun 18, 2020
c808137
Reference to ci dir consistently in all pipelines
Jun 18, 2020
ac43446
Remove check git status
Jun 18, 2020
9687ea4
Fix unit tests
Jun 18, 2020
1bf3f4a
Remove clone steps from update jobs
Jun 26, 2020
e61e34a
Add Cilium 1.7 manifests
dirkmueller Jun 11, 2020
5edcfba
Set config values defaults for cilium 1.7 the same way like with 1.6
dirkmueller Jun 17, 2020
20e781c
[terraform] Enable security group management in CPI config (#1182)
stefannica Jun 29, 2020
f7ad64e
Use the SUSE NTP pool servers instead of Novell (#1201)
dirkmueller Jun 29, 2020
2b09b7e
Fix typo and rewording (#1203)
c3y1huang Jun 29, 2020
b625aae
Use env var for AWS credentials (#1190)
spiarh Jun 29, 2020
e5eb51d
Merge pull request #1168 from pablochacin/remove-pr-scm-logic
pablochacin Jun 29, 2020
9f62c4d
Merge pull request #1191 from mjura/crio-update
evrardjp Jun 29, 2020
16e1396
Bump kubernetes libraries to 1.18.5
Jun 24, 2020
d15c7f7
Merge pull request #1204 from chentex/bump-k8s-libs-to-1.18.4
evrardjp Jun 29, 2020
80ee101
Merge pull request #1155 from dirkmueller/cilium17
davidcassany Jun 29, 2020
2966e8f
Support Patternless packages
evrardjp Jun 19, 2020
c5be42b
Use the Proper SLE15 SP2 JeOS GM image for testing in CI
dirkmueller Jun 26, 2020
7d84e9d
Remove basedir from scm definition in ci jobs
Jun 30, 2020
fdae379
Merge pull request #1211 from pablochacin/remove-basedir-in-scm
pablochacin Jun 30, 2020
ba48dff
Merge pull request #1200 from dirkmueller/imagefix
jordimassaguerpla Jun 30, 2020
b9d59d1
Fix golangci-lint invocation
dirkmueller Jun 29, 2020
48dd304
Update shellcheck to latest 0.7.1 release
dirkmueller Jun 30, 2020
871aaad
Merge pull request #1178 from evrardjp/patternless
evrardjp Jun 30, 2020
3ceeffc
Fix development image registry references (#1212)
davidcassany Jun 30, 2020
4a20e4c
Merge pull request #1208 from dirkmueller/fixlint
dirkmueller Jun 30, 2020
8ec8393
Fix the reboot logic
dirkmueller Jun 29, 2020
8a43a5c
Fix reference to skuba subdir in conformance test
Jul 1, 2020
6406feb
Fix stage1 upgrade
evrardjp Jun 30, 2020
858763f
Tumbleweed container has no diff cmd
evrardjp Jun 17, 2020
55ad7d7
Merge pull request #1217 from evrardjp/fix_upgrade_from_1.17
evrardjp Jul 1, 2020
e55d97d
Fix stage2 upgrade
evrardjp Jul 1, 2020
0917b06
Merge pull request #1169 from evrardjp/tumbleweed-container-has-no-di…
evrardjp Jul 1, 2020
bf1fbc3
Merge pull request #1218 from evrardjp/fix_upgrade_from_1.17-stage2
evrardjp Jul 1, 2020
5e474f3
Merge pull request #1205 from dirkmueller/rebootfix
dirkmueller Jul 1, 2020
5d40e56
Avoid pulling plugins from the Terraform online repositry
dirkmueller Jun 30, 2020
f8ace1c
Merge pull request #1216 from pablochacin/fix-conformace-test
JanZerebecki Jul 1, 2020
ca6b943
Switch to SLE15-SP2 base images and change references to v5
dirkmueller Jun 29, 2020
b1e2124
Merge pull request #1207 from dirkmueller/morev5
dirkmueller Jul 2, 2020
83c47fd
allow ssh through bastion with skuba
Jun 23, 2020
3525deb
use sles as default ssh user
Jun 26, 2020
16d3614
do not set a default SSH user
Jun 26, 2020
d85678b
Allow key host check for host behind bastion
Jun 26, 2020
f9dc5e1
update manpages
Jul 2, 2020
5feba07
Fix packaging script
davidcassany Jul 3, 2020
54ba5e2
Merge pull request #1221 from davidcassany/fix_packaging_script
davidcassany Jul 3, 2020
f0e1d13
add missing tags and format AWS
Jul 3, 2020
c467d82
Merge pull request #1222 from lcavajani/add_missin_tags_lb
spiarh Jul 3, 2020
c7e7b6c
test: Bump Cilium version
vadorovsky Jul 3, 2020
d6a20b6
mark ssh user flag as required
Jul 3, 2020
60bff42
add required to user flag in doc
Jul 6, 2020
7d49333
Merge pull request #1213 from dirkmueller/avoid_plugins_install
dirkmueller Jul 6, 2020
6808a1b
Allow any version of k8s-client
evrardjp Jul 6, 2020
92f652b
Enable ExtendedResourceToleration by default (#1192)
cmurphy Jul 6, 2020
2fd071d
Add Openstack credentials to PR test job
Jul 7, 2020
0e0c8e4
Remove cri-o-kubeadm-criconfig in stage1
evrardjp Jul 6, 2020
8ed1de1
Merge pull request #1231 from pablochacin/add-os-credentials-to-pr
davidcassany Jul 7, 2020
1ae65ed
Gather logs only if platform was provisioned
Jul 7, 2020
00cb473
Merge pull request #1223 from mrostecki/cilium-ver-bump-tests
mmnelemane Jul 7, 2020
28590b3
CI: Bump vmware image to latest
Jul 7, 2020
592952e
Merge pull request #1185 from lcavajani/add_bastion
spiarh Jul 7, 2020
a7eceb5
Merge pull request #1233 from Itxaka/bump_vmware_image
pablochacin Jul 7, 2020
74366c3
fixup! Allow any version of k8s-client
evrardjp Jul 7, 2020
fa410d6
Merge pull request #1227 from evrardjp/update-virtual-provides-to-k8s
davidcassany Jul 7, 2020
6a1350a
Fix log message when service restart fail (#1121)
jvanz Jul 8, 2020
f1d8360
Merge pull request #1232 from pablochacin/skip-getlogs-if-no-provisioned
pablochacin Jul 8, 2020
0765f44
CI: disable routable check for vmware
Jul 8, 2020
696b72d
Retain cluster in case of failure
Jul 3, 2020
193a64c
Add cluster retention parameters to manual e2e test
Jul 6, 2020
bef84ca
fix original registry in jenkinsfile
jordimassaguerpla Jul 9, 2020
b270b97
Unify platform definitions in the CI
Jul 9, 2020
c9bd1c1
Merge pull request #1239 from jordimassaguerpla/fix_original_registry…
jordimassaguerpla Jul 9, 2020
b76aeba
Update kured to 1.4.3
dirkmueller Jun 30, 2020
44891bb
Merge pull request #1244 from jordimassaguerpla/kured_update
jordimassaguerpla Jul 9, 2020
92d79e8
Clarify some code (#1070)
evrardjp Jul 10, 2020
6880fe8
Merge pull request #1219 from pablochacin/pause-failed-e2e-test
pablochacin Jul 10, 2020
bb9a473
Merge pull request #1236 from Itxaka/disable_net_routable_check
jordimassaguerpla Jul 10, 2020
d3c5001
New command: skuba addon refresh localconfig (bsc#1173055) (#1226)
Jul 13, 2020
bd6ca7e
Add Resource Groups + AZ filter for AWS tf (#1225)
spiarh Jul 13, 2020
15bcc03
Install cri-tools-<cri_version>
evrardjp Jul 14, 2020
e7a60bb
Merge pull request #1241 from pablochacin/unify-platform-configuratio…
Jul 14, 2020
339fd5a
Merge pull request #1252 from evrardjp/cri-tools-with-version-appended
davidcassany Jul 14, 2020
df967d7
Remove cri-tools on upgrade
evrardjp Jul 14, 2020
5165385
Merge pull request #1253 from evrardjp/remove-cri-tools
evrardjp Jul 14, 2020
1d63166
Skuba auth login oidc ca (#1249)
Jul 15, 2020
8439525
Revert kubelet server tls bootstrap (#1248)
Jul 15, 2020
21b77b6
Ensure services are enabled
evrardjp Jul 15, 2020
1ce1321
Upgrade to k8s from 1.17.4 to 1.17.9
davidcassany Jul 17, 2020
1d098f6
Merge pull request #1261 from davidcassany/upgrade_k8s_caaspv4
davidcassany Jul 17, 2020
6bbe87f
cri: handle the migration to the new configuration format
mssola Jul 14, 2020
ee9666c
Merge pull request #1251 from mssola/crio-migration
mssola Jul 17, 2020
ee26237
Fix incorrect output of `skuba cluster images` (#1266)
innobead Jul 20, 2020
46f7ed1
Update Kubernetes to 1.18.6
mjura Jul 20, 2020
6a03491
Merge pull request #1259 from evrardjp/ensure-services-are-enabled
Jul 20, 2020
e8aca93
Patternless cosmetic cleanups (#1210)
evrardjp Jul 20, 2020
ca1485f
Merge pull request #1269 from mjura/k8s-1.18.6
davidcassany Jul 21, 2020
588cafc
Fix name of kubernetes client package
Jul 21, 2020
fd8d7ed
Enhance skuba addon upgrade [plan|apply] (#1247)
Jul 23, 2020
55e8fa0
Merge pull request #1275 from pablochacin/fix-k8s-client-package
Jul 24, 2020
312c9d4
Update node repositories to official SP2 repos
davidcassany Jul 24, 2020
068d9c7
Merge pull request #1276 from davidcassany/update_to_official_SP2_repos
davidcassany Jul 24, 2020
ec24f1a
Provide a test for istio ingress in testrunner
manuelbuil Jul 20, 2020
0b28a5a
Make sure k8s 1.17.9 is appended and not substituting 1.17.4
davidcassany Jul 28, 2020
195818d
Merge pull request #1281 from manuelbuil/istio-tests
manuelbuil Jul 28, 2020
dcda9ca
Merge pull request #1286 from davidcassany/fix_versions.go_file
davidcassany Jul 29, 2020
64bcb67
Fix a bug in the test
manuelbuil Jul 28, 2020
9d5fd8e
Merge pull request #1288 from manuelbuil/fix-test-bug
manuelbuil Jul 29, 2020
d4af7d3
Add Istio TLS ingress test
manuelbuil Jul 28, 2020
75d5362
Merge pull request #1289 from manuelbuil/istio-TLS-test
manuelbuil Jul 30, 2020
3ea5acc
Drop hyperkube image for version > v1.17
mjura Jul 30, 2020
1f8158a
Merge pull request #1293 from mjura/usehyperkube_17
mjura Jul 31, 2020
d05fdd1
fix gangway revision (bsc#1173165)
jordimassaguerpla Aug 3, 2020
3eab1a2
Merge PR into targe Branch before building
Jun 9, 2020
7ca6606
Drain nodes before kubadm upgrade and uncordon afterwards
saschagrunert Jul 23, 2020
b7aff74
Merge pull request #1285 from pablochacin/merge-pr-before-build
jordimassaguerpla Aug 3, 2020
7a8854a
Merge pull request #1277 from saschagrunert/drain-uncordon
Aug 3, 2020
aec8d7c
Merge pull request #1296 from jordimassaguerpla/fix_gangway_revision
jordimassaguerpla Aug 3, 2020
c29e13e
Remove addon upgrade test from pr pipeline
Aug 3, 2020
1637ade
Merge pull request #1299 from pablochacin/remove-addon-update-test-fr…
jordimassaguerpla Aug 3, 2020
6d1bd6e
updated version to v4.5
Jul 30, 2020
0675836
updated to fix missed versions
Jul 30, 2020
0dec0e2
Merge pull request #1294 from Klaven/version-update
jordimassaguerpla Aug 3, 2020
16f336f
Revert k8s 1.17.9 upgrade
davidcassany Jul 30, 2020
752446e
Merge pull request #1297 from jordimassaguerpla/revert_k8s_1_17_4
jordimassaguerpla Aug 4, 2020
4772c24
Add the CA repo
manuelbuil Aug 5, 2020
4685f20
Merge pull request #1309 from manuelbuil/suse_ca
manuelbuil Aug 5, 2020
dff3471
Update to cilium 1.7.6 (bsc#1173559)
dirkmueller Aug 4, 2020
ed0de26
Replace OIDC server certificates signed by custom/trusted certificate…
Aug 6, 2020
43df420
Re-render all addons base manifest during bootstrap (#1312)
Aug 6, 2020
705c864
Fixes selection of kubeadm-criconfig version (#1311)
Aug 6, 2020
3f29431
Skip PR test in master/release branches (#1301)
Aug 6, 2020
0874a7d
Lock kured after disabling skuba-update.timer
mjura Jul 30, 2020
ad3d731
Fix K8s version in upgrade tests for maintenance
Aug 10, 2020
5817004
Merge pull request #1303 from dirkmueller/cilium
vadorovsky Aug 10, 2020
7e1d09f
Merge pull request #1290 from mjura/kured-lock
vadorovsky Aug 10, 2020
fa6e9c9
Merge pull request #1314 from pablochacin/fix-k8s-version-maintenance
Aug 11, 2020
b53e939
update suggestions for add features in aws mutlti zone support
Aug 17, 2020
a3c135f
Fix addrepo
Aug 20, 2020
1317c3c
add sles user and update formatting
Sep 17, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
19 changes: 19 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# docs: https://help.github.com/en/articles/about-code-owners

# This is a comment.
# Each line is a file pattern followed by one or more owners.

# These owners will be the default owners for everything in
# the repo. Unless a later match takes precedence,
# @global-owner1 and @global-owner2 will be requested for
# review when someone opens a pull request.
# * @global-owner1 @global-owner2

# Order is important; the last matching pattern takes the most
# precedence.

# The codeowners of this file are the repository admins
.github/CODEOWNERS @ereslibre @flavio @innobead @jordimassaguerpla @stefsuse

# A file/directory pattern or domain MUST have at least 3 codeowners before
# it is added to this file.
60 changes: 60 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
## Why is this PR needed?

Does it fix an issue? addresses a business case?

add a description and link to the issue if one exists.

Fixes #

**Reminder**: Add the "fixes bsc#XXXX" to the title of the commit so that it will
appear in the changelog.

## What does this PR do?

please include a brief "management" technical overview (details are in the code)

## Anything else a reviewer needs to know?

Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.

## Info for QA

This is info for QA so that they can validate this. This is **mandatory** if this PR fixes a bug.
If this is a new feature, a good description in "What does this PR do" may be enough.

### Related info

Info that can be relevant for QA:
* link to other PRs that should be merged together
* link to packages that should be released together
* upstream issues

### Status **BEFORE** applying the patch

How can we reproduce the issue? How can we see this issue? Please provide the steps and the prove
this issue is not fixed.

### Status **AFTER** applying the patch

How can we validate this issue is fixed? Please provide the steps and the prove this issue is fixed.

## Docs

If docs need to be updated, please add a link to a PR to https://github.com/SUSE/doc-caasp.
At the time of creating the issue, this PR can be work in progress (set its title to [WIP]),
but the documentation needs to be finalized before the PR can be merged.

# Merge restrictions

(Please do not edit this)

We are in *v4-maintenance phase*, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
2 approvals:
1 developer: code is fine
1 QA: QA is fine
there is a PR for updating documentation (or a statement that this is not needed)

<!-- Remember, if this is a work in progress please pre-append [WIP] to the title until you are ready!
If you can, please apply all applicable labels to help reviews out! -->
14 changes: 13 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,16 @@
.glide/

# Binary folder
/bin
/bin

# RPM files folder
ci/packaging/suse/obs_files

# ignore coverage result
/coverage.out

# ignore skuba
/skuba

# ignore junit files
ci/infra/testrunner/pr.xml
82 changes: 82 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
linters-settings:
govet:
check-shadowing: true
golint:
min-confidence: 0
gocyclo:
min-complexity: 15
maligned:
suggest-new: true
dupl:
threshold: 100
goconst:
min-len: 2
min-occurrences: 2
misspell:
locale: US
lll:
line-length: 140
goimports:
local-prefixes: github.com/golangci/golangci-lint
gocritic:
enabled-tags:
- diagnostic
- experimental
- opinionated
- performance
- style
disabled-checks:
- wrapperFunc
- dupImport # https://github.com/go-critic/go-critic/issues/845
- ifElseChain
- octalLiteral
funlen:
lines: 100
statements: 50

linters:
# please, do not use `enable-all`: it's deprecated and will be removed soon.
# inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
disable-all: true
enable:
- bodyclose
- deadcode
- depguard
- dogsled
- errcheck
- gofmt
- goimports
- gosimple
- ineffassign
- misspell
- nakedret
- staticcheck
- structcheck
- typecheck
- unconvert
- varcheck
- whitespace

# TODO: enable these linters
# - dupl
# - scopelint
# - golint
# - funlen
# - lll
# - gosec
# - gocritic
# - govet
# - gochecknoinits
# - interfacer
# - unparam
# - unused
# - goconst
# - gocyclo
# - stylecheck

run:
skip-dirs-use-default: true
skip-dirs:
- docs
- bin
- ci
45 changes: 45 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# See https://pre-commit.com for more information
# See https://pre-commit.com/hooks.html for more hooks
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v2.4.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
- id: check-symlinks
- id: check-merge-conflict
- id: check-yaml
- id: check-executables-have-shebangs
- repo: local
hooks:
- id: go-fmt
name: go fmt
entry: ./scripts/go-fmt.sh
files: '\.go$'
language: script
- id: go-vet
name: go vet
entry: ./scripts/go-vet.sh
files: '\.go$'
language: script
- id: go-imports
name: go imports
entry: ./scripts/go-imports.sh
files: '\.go$'
language: script
- repo: https://github.com/golangci/golangci-lint
rev: v1.27.0
hooks:
- id: golangci-lint
args: [--verbose, --timeout=3m]
files: '\.go$'
- repo: https://github.com/pre-commit/mirrors-autopep8
rev: v1.4.4
hooks:
- id: autopep8
files: '\.py$'
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.21.0
hooks:
- id: terraform_fmt
files: '\.tf$'
83 changes: 83 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
# Contributing to skuba

The following is a set of guidelines for contributing to this project, hosted by [SUSE](https://github.com/suse/skuba).
If you have a suggestion to these guidelines feel free to propose changes in a pull request.


## Pull requests

Contributors:
* Adhere to the PR template. Fill out as many sections as possible with as much detail as possible.
* Adhere to the style guide as closely as possible, where a bot cannot do it for you.
* The PR is ready for review only when the CI is green. Do not ask for people to review your code if the CI is failing.
* If CI is not passing, or you need to make more improvements than expected, please add the wip label.
* Once the CI is green, feel free to assign specific reviewers to your PR to signal it is ready.
* Do NOT merge pull requests. CI will automatically merge the PR once tests pass and approvals are received.

Maintainers:
* Devote time to regular code review and make your reviews impactful. Look at the big picture, don't get hung up on style alone.
* Veto only when there's is something really problematic, otherwise just comment. Otherwise you are forcing a new round of reviews including a new CI run.
* Add yourself to the [CODEOWNERS](.github/CODEOWNERS) file if you want to be assigned automatically as reviewer in a particular area.


## Styleguides

### git commit messages

This list is not comprehensive, meaning if you want to include more detail than required that is fine as long as you meet these guidelines first.

* Title
* Always start with an upper-case letter
* Do not put a dot (period) at the end
* Use imperative verbs
* Maximum characters: 50 (excluding the (bsc#123456) part)
* Tracking issues from Bugzilla
* Add `(bsc#123456)` as part of the title

* Body
* Start sentences with upper-case letter and finish with dot (period).
* Maximum characters per line is 72
* Explain what this commit is doing
* Explain why we have to do it
* Do not explain how unless the change is sufficiently large and needs further explanation
* Tracking issues from Github:
* __Do not track references (ID/URLs) to in the commit message__ but on the web-ui (yes you are forced to open your browser)

## Go style

This will be checked automatically by our CI linter bot.

## Releasing

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ If you are releasing a new kubernetes version, or any other container, +
+ make sure the versions.go has been updated accordingly. See as an +
+ example: +
+ https://github.com/SUSE/skuba/pull/573 +
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

In order to create a new release, perform the following steps:

* Create a tag:
* Tag with `vX.Y.Z`: `git tag -s vX.Y.Z -m "Tag X.Y.Z" <commit>`
* Allowed tag format:
* `vX.Y.Z-alphaN?`: creates an alpha release (e.g. `v1.0.0-alpha`,
`v1.0.0-alpha3`)
* `vX.Y.Z-betaN?`: creates a beta release (e.g. `v1.0.0-beta`,
`v1.0.0-beta1`)
* `vX.Y.Z-rcN?`: creates a release candidate (e.g. `v1.0.0-rc`,
`v1.0.0-rc2`)
* `vX.Y.Z`: creates a final release
* `<commit>` argument can be omitted if you want the tag to point to `HEAD`

* Push the tag: `git push <remote> vX.Y.Z`
* Note: `<remote>` should be pointing to the
`github.com/SUSE/skuba` repository

* Checkout the tag: `git checkout vX.Y.Z`

* Create the changelog: `make suse-package`

* Add a new release at https://github.com/SUSE/skuba/releases with the contents from the file `ci/packaging/suse/obs_files/skuba.changes.append`

* Use the files in `ci/packaging/suse/obs_files` to update the skuba package
Loading