Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuned regex for normal escapes #3

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

DavyLandman
Copy link
Member

@DavyLandman DavyLandman commented Jul 9, 2024

I've added support for \xHH escapes for ascii chars, and also enabled \r\n\t and friends.

@DavyLandman DavyLandman requested a review from sungshik July 9, 2024 11:18
@DavyLandman DavyLandman force-pushed the feat/nicer-regex-for-normal-chars branch from b242afa to aae40ab Compare July 9, 2024 13:43
Copy link
Collaborator

@sungshik sungshik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, just a few nits

@DavyLandman DavyLandman merged commit 9f3d91c into main Jul 10, 2024
2 checks passed
@DavyLandman DavyLandman deleted the feat/nicer-regex-for-normal-chars branch July 12, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants