Support new soap output format #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgeniiChaikin
approved these changes
Nov 8, 2024
| @@ -1526,6 +1486,7 @@ def VR_to_SOAP(particle_property_name: str) -> str: | |||
| "exclusivesphere.100kpc.linearmassweightedironfromsniaoverhydrogenofstars", | |||
| -1, | |||
| ), | |||
| "searchradius.search_radius": ("boundsubhalo.encloseradius", -1), | |||
There was a problem hiding this comment.
I see that the search radius field was not in the translator file before. Do we now need this field somewhere?
There was a problem hiding this comment.
It is used by the morphology pipeline when we are deciding what region of the simulation to read in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the SOAP reader functionality to support the HBT SOAP output. Also adds some new properties to the translator file