Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokeninfo #348

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Tokeninfo #348

merged 2 commits into from
Sep 29, 2023

Conversation

waelhanfi04
Copy link
Contributor

Pull Request Description

Summary:
This pull request introduces several changes across the codebase, enhancing the functionality of the application by adding support for fetching cryptocurrency chart data, enriching cryptocurrency details, and improving data retrieval for prices. Below is a detailed overview of the changes made:

Changes in .env.example:

  • Added a new environment variable CMC_CRYPTO_CHART to store the CoinMarketCap cryptocurrency chart API endpoint.

Changes in controllers/wallet.controller.js:

  • Added a new function getChart to the wallet.controller.js module.
  • Created a new API endpoint getCharts that retrieves cryptocurrency chart data based on provided parameters.

Changes in routes/wallet.routes.js:

  • Added a new route handler for the getCharts endpoint, linking it to the getCharts function in the wallet.controller.js module.
  • Added Swagger documentation for the new getCharts API endpoint.

Changes in web3/wallets.js:

  • Enhanced the getNetworkByToken function to include additional information such as contract_address, description, and urls in the network data.
  • Improved the getPrices function to include additional data fields in the response, such as fully_diluted, market_cap, percent_change_24h, and volume_change_24h.
  • Enriched the response data structure with description, urls, and network properties.
  • Modified the code to handle multiple network platforms and select relevant information based on platform names.
  • Introduced the ability to fetch cryptocurrency chart data using the getChart function.

These changes aim to provide more comprehensive cryptocurrency information, including chart data, and improve the overall data retrieval process.

Please review and merge this pull request to incorporate these enhancements into the application.

@waelhanfi04 waelhanfi04 merged commit a234d60 into develop Sep 29, 2023
@waelhanfi04 waelhanfi04 deleted the tokeninfo branch September 29, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token Info Optimization and API Replacement
2 participants