Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harvest #385

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Harvest #385

merged 2 commits into from
Jan 5, 2024

Conversation

waelhanfi04
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 5, 2024
View reviewed changes
routes/external.routes.js
@@ -159,4 +163,10 @@

router.post('/apply', verifySignatureMiddleware,externalApply)

router.post('/checkHarvest', verifySignatureMiddleware, checkHarvest)

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
routes/external.routes.js
@@ -159,4 +163,10 @@

router.post('/apply', verifySignatureMiddleware,externalApply)

router.post('/checkHarvest', verifySignatureMiddleware, checkHarvest)

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
routes/external.routes.js
@@ -159,4 +163,10 @@

router.post('/apply', verifySignatureMiddleware,externalApply)

router.post('/checkHarvest', verifySignatureMiddleware, checkHarvest)

router.post('/externalAnswer', verifySignatureMiddleware, externalAnswer)

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
routes/external.routes.js
@@ -159,4 +163,10 @@

router.post('/apply', verifySignatureMiddleware,externalApply)

router.post('/checkHarvest', verifySignatureMiddleware, checkHarvest)

router.post('/externalAnswer', verifySignatureMiddleware, externalAnswer)

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
routes/external.routes.js
router.post('/checkHarvest', verifySignatureMiddleware, checkHarvest)

router.post('/externalAnswer', verifySignatureMiddleware, externalAnswer)
router.post('/externalGains', verifySignatureMiddleware, externalGains)

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
controllers/external.controller.js

var tronWeb
await CampaignLink.updateOne(
{ id_prom: req.body.idProm },

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
Loading
.
controllers/external.controller.js
Comment on lines +1312 to +1314
var link = await CampaignLink.findOne({
id_prom: req.body.idProm,
}).lean()

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
Loading
.
controllers/external.controller.js
)
let updatedFUnds = { ...req.body.data.data }

let cmpLink = await CampaignLink.findOne({ id_prom: req.body.idProm }).lean()

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
Loading
.
controllers/external.controller.js
: new Big(cmpLink.payedAmount).plus(new Big(amount)).toFixed()
updatedFUnds.type = 'already_recovered'
await CampaignLink.updateOne(
{ id_prom: req.body.idProm },

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
Loading
.
controllers/external.controller.js
updatedFUnds.type = 'already_recovered'
await CampaignLink.updateOne(
{ id_prom: req.body.idProm },
{ $set: updatedFUnds }

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
Loading
.
@waelhanfi04 waelhanfi04 merged commit f7d19ea into develop Jan 5, 2024
2 of 4 checks passed
@waelhanfi04 waelhanfi04 deleted the harvest branch January 5, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@waelhanfi04