Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arthera evm integration #419

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Arthera evm integration #419

merged 4 commits into from
Feb 14, 2024

Conversation

hichri-louay
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 14, 2024
View reviewed changes
routes/wallet.routes.js

router.post(
'/code-export-keystore',
verifyAuth,

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
routes/wallet.routes.js
'/code-export-keystore',
verifyAuth,
getCodeKeyStoreValidation,
getCodeKeyStore

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
authorization
Loading
, but is not rate-limited.
routes/wallet.routes.js
router.get('/nfts/:address', checkEVMValidation,getNftByAddress)
router.post(
'/export-keystore',
verifyAuth,

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
routes/wallet.routes.js
'/export-keystore',
verifyAuth,
exportKeyStoreValidation,
exportKeyStore

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
routes/wallet.routes.js

router.post('/export-keystore-mobile', verifyAuth, exportKeyStoreMobile)

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
web3/campaigns.js
{ hash: hash },
{ $set: { retrieved: true } }
)
await Campaigns.updateOne({ hash: hash }, { $set: { retrieved: true } })

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query object depends on a
user-provided value
Loading
.
routes/campaign.routes.js
*/
router.post(
'/arthera/approval',
verifyAuth,

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
routes/campaign.routes.js
'/arthera/approval',
verifyAuth,
evmApprovalValidation,
artheraApproval

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a system command
Loading
, but is not rate-limited.
routes/campaign.routes.js
* "500":
* description: error:"error"
*/
router.post('/arthera/allow', verifyAuth, artheraAllow)

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
routes/campaign.routes.js
* "500":
* description: error:"error"
*/
router.post('/arthera/allow', verifyAuth, artheraAllow)

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
@hichri-louay hichri-louay merged commit d1cfe44 into develop Feb 14, 2024
2 of 3 checks passed
@hichri-louay hichri-louay deleted the arthera-evm-integration branch February 14, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hichri-louay