Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokeninfo #533

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Tokeninfo #533

merged 2 commits into from
Sep 19, 2023

Conversation

waelhanfi04
Copy link
Contributor

Description:
This pull request introduces several enhancements to the Crypto Market Cap page and adds a new guard to protect access to it. Here's a breakdown of the changes made in this pull request:

  1. Crypto Market Cap Page Updates:

    • The CryptoMarketCapComponent in crypto-market-cap.component.ts has been improved with the following changes:
      • The page now displays a search input field to filter cryptocurrencies by name.
      • Pagination functionality has been added to navigate through the list of cryptocurrencies.
      • The UI now displays sparkline graphs for each cryptocurrency, with color coding based on the 7-day percentage change.
  2. Crypto Data Guard:

    • A new Angular route guard named CryptoDataGuard has been implemented in crypto-data.guard.ts. This guard is designed to protect access to the Crypto Market Cap page.
    • If the user attempts to access the Crypto Market Cap page and there is no cryptocurrency data available in the store, the guard triggers a data loading action to fetch the required data.
    • The guard only allows access to the page if the cryptocurrency data is successfully loaded; otherwise, it prevents access.
  3. Redux Store Integration:

    • Redux store integration has been enhanced to manage cryptocurrency data using the NgRx store.
    • Actions, effects, selectors, and reducers have been added to facilitate the loading and management of cryptocurrency data.
  4. Other Miscellaneous Updates:

    • Some minor code cleanup and optimizations have been performed in the codebase.

These changes collectively enhance the user experience of the Crypto Market Cap page by providing search and pagination capabilities, ensuring data availability through the guard, and implementing state management for cryptocurrency data using NgRx.

Please review these changes and provide your feedback.

@waelhanfi04 waelhanfi04 linked an issue Sep 19, 2023 that may be closed by this pull request
@hichri-louay hichri-louay merged commit 0038295 into develop Sep 19, 2023
3 checks passed
@hichri-louay hichri-louay deleted the tokeninfo branch September 19, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token Page Performance and Functionality Optimization
2 participants