Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixmigrationwallet #539

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fixmigrationwallet #539

merged 2 commits into from
Sep 19, 2023

Conversation

waelhanfi04
Copy link
Contributor

Summary:
This pull request aims to enhance the authentication and balance fetching logic within the codebase. It introduces changes to the verifyAccount method and the determination of the wallet version based on the fetched balance.

Details:
In this pull request, we make the following modifications:

  1. We use the verifyAccount method, which appears to be an asynchronous operation, and we utilize the pipe operator to handle the result.

  2. Inside the pipe, we've introduced a tap operator to handle the result of the verifyAccount method asynchronously. This allows us to perform additional actions based on the verification result.

  3. We've added an asynchronous operation to fetch the balance using the fetchBalance method and store it in the fetchedBalance variable.

  4. We determine the walletVersion based on the value of fetchedBalance. If fetchedBalance is equal to 0.0, we set walletVersion to 'v1', otherwise, it's set to 'v2'.

Additional Context:
If there is any additional information or context that would be helpful for the reviewers to understand the changes better, please provide it here.


Feel free to customize this pull request description to fit your specific project and team's needs.

@waelhanfi04 waelhanfi04 linked an issue Sep 19, 2023 that may be closed by this pull request
3 tasks
@hichri-louay hichri-louay merged commit d0ae6eb into develop Sep 19, 2023
3 checks passed
@hichri-louay hichri-louay deleted the fixmigrationwallet branch September 19, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect display/current balance/old wallet
2 participants