Sw 3653 adpool banner in french #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…component removing extra div floating the button right and removing extra dependancies and margins , handle new screen of max width 350px
hichri-louay
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note For Reviewers
The key improvements in this commit include:
Button Refactoring: We've made substantial improvements to the button's structure. This includes removing extra div elements, which were previously causing some inconsistencies. Now, the button is more straightforward and elegant in its implementation.
Dependancy Cleanup: We've diligently reviewed and removed any unnecessary dependencies, ensuring that our codebase remains lean and efficient.
Responsive Design: We've also handled the button's appearance on screens with a maximum width of 350px. This ensures that our design is responsive and visually appealing across various screen sizes.
By making these changes, we aim to enhance the user experience and streamline our codebase. Your feedback and insights on these improvements would be highly valuable.
Thank you for your review!
Best regards,
Skander Khabou