Cryptolist network #588
Merged
Cryptolist network #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Summary:
This pull request enhances the filtering logic for a list of items based on specified keys. The primary goal is to display items with specific keys from the
keysToDisplayarray, and in case a key is not found, replace it with a randomly selected key from the same array.Changes Made:
Added a
getRandomKey()function to generate a random key from thekeysToDisplayarray.Modified the existing code to use
mapinstead offilterfor iterating through thefilterList.For each item in
filterList, we now check if itskeyis included inkeysToDisplay. If it is, the originalkeyis retained. If not, we replace it with a random key generated usinggetRandomKey().Why This PR is Necessary:
This PR improves the filtering and display of items by ensuring that the specified keys are included in the result while handling cases where a key is not found gracefully by substituting it with a random key. This enhancement provides a more robust and user-friendly experience when working with the data.