574 restrict length of title components and keep it one line in web view #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a 100% width and fix the brand to fit all the screens
hichri-louay
approved these changes
Oct 2, 2023
hichri-louay
deleted the
574-restrict-length-of-title-components-and-keep-it-one-line-in-web-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for Review:
In this commit, I have addressed the issue related to the campaign title and brand not fitting properly on various screen sizes. To resolve this, I made adjustments to the campaign title, ensuring it now spans the entire width of the screen. This change guarantees that the campaign title is fully visible and properly aligned regardless of the screen dimensions.
Additionally, I worked on the brand display, making sure it also adapts seamlessly to different screen sizes. This enhancement enhances the overall user experience and ensures that our application looks consistent and professional across various devices.
The modifications made in this commit were thoroughly tested to confirm that they do not negatively impact other elements of the user interface. Everything appears to be working as expected.
Your feedback and insights on these changes will be greatly appreciated.
Best regards,
Skander Khabou