SWC-6605: fix handling of intermittently appearing file upload alert

Sage-Bionetworks · Nov 28, 2023 · 6fdcb49 · 6fdcb49
1 parent c2f3cd7
commit 6fdcb49
Showing 1 changed file with 11 additions and 13 deletions.
diff --git a/e2e/files.spec.ts b/e2e/files.spec.ts
@@ -422,21 +422,19 @@ test.describe('Files', () => {
       await testAuth.step('upload a new file', async () => {
         await uploadFile(userPage, updatedFilePath, 'newVersion')
         await expectFilePageLoaded(fileName, fileEntityId, userPage)
-        await dismissFileUploadAlert(userPage)
+        // Upload success alert intermittently appears when uploading a new version of the same file
+        await testAuth.step(
+          'dismiss file upload alert for new version of file, if visible',
+          async () => {
+            if (
+              await userPage.getByText('File successfully uploaded').isVisible()
+            ) {
+              await dismissFileUploadAlert(userPage)
+            }
+          },
+        )
       })
 
-      // Upload success alert intermittently appears when uploading a new version of the same file
-      await testAuth.step(
-        'dismiss file upload alert for new version of file, if visible',
-        async () => {
-          if (
-            await userPage.getByText('File successfully uploaded').isVisible()
-          ) {
-            await dismissFileUploadAlert(userPage)
-          }
-        },
-      )
-
       await testAuth.step(
         'confirm uploading new file changed md5 and version',
         async () => {